Top-level functions are shadowed by sub-module funcs #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that in torch -> tfjs conversion,
tf.reshape
is overridden bytf.layers.reshape
, which has different arguments.Correct translation would be
torch.reshape
->tf.reshape
, buttf.layers.reshape
has same key in the funcs map and overwritestf.reshape
when the map is populated.I'm trying to solve that by giving priority to functions that has shorter
attrs
path.This kinda works, but it seems the problem needs more correct fix that would keep both funcs in the map but differentiate them by sub-module on mapping time?
Affected Dependencies
n/a
How has this been tested?
Unit tests
Checklist