Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly parse & fuzzy match including package names 💭 #16

Open
Nolski opened this issue Feb 4, 2020 · 0 comments
Open

Properly parse & fuzzy match including package names 💭 #16

Nolski opened this issue Feb 4, 2020 · 0 comments
Assignees
@Nolski
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Priority: 4 - Low 😎 Should only be scheduled if it's important relative to other issues Severity: 3 - Medium 😒 Does not cause a failure, impair usability, or interfere with the system Status: Available 👋 Available for assignment, who wants it? Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Milestone
0.3.0

Comments

@Nolski
Copy link
Collaborator

Nolski commented Feb 4, 2020

Summary

function_name from our scraped docs is not universal. We should fuzzy match using other items such as parent package.

Background

Is the improvement related to a problem? If yes, please describe:

Matching on only function_name can cause incorrect translation without alerting the user. We want to be very careful to not allow this to happen.

Describe the ideal solution:

We should parse & include other information such as parent package name in order to ensure that proper translations occur. Perhaps we should even be wary to translate unless we're absolutely sure that the translation is correct.

Outcome

Inclusion of package path in determine translations to ensure more accurate translations.
@Nolski Nolski added Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor needs triage Metadata needs to be triaged and updated labels Feb 4, 2020
@Nolski Nolski self-assigned this Feb 4, 2020
@Nolski Nolski removed the needs triage Metadata needs to be triaged and updated label Feb 5, 2020
@cereallarceny cereallarceny added Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Priority: 4 - Low 😎 Should only be scheduled if it's important relative to other issues Severity: 3 - Medium 😒 Does not cause a failure, impair usability, or interfere with the system Status: Available 👋 Available for assignment, who wants it? labels May 31, 2020
@cereallarceny cereallarceny added this to the 0.2.0 milestone Jul 1, 2020
@Nolski Nolski mentioned this issue Jul 6, 2020
Merged
4 tasks
@vvmnnnkv vvmnnnkv mentioned this issue Jul 7, 2020
Open
@Nolski Nolski mentioned this issue Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nolski Nolski

Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Priority: 4 - Low 😎 Should only be scheduled if it's important relative to other issues Severity: 3 - Medium 😒 Does not cause a failure, impair usability, or interfere with the system Status: Available 👋 Available for assignment, who wants it? Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@cereallarceny @Nolski