Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to TFJS-traslated plans #174

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Conversation

vvmnnnkv
Copy link
Member

@vvmnnnkv vvmnnnkv commented Jul 8, 2020

Description

Fixes #172

  • Execute Plan as if it's already translated to TFJS
  • Remove threepio dependency

Affected Dependencies

The test data that passes unit tests is generated on this PySyft branch: OpenMined/PySyft#3802

How has this been tested?

Unit tests pass

Checklist

@vvmnnnkv vvmnnnkv added Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase labels Jul 8, 2020
@cereallarceny cereallarceny requested a review from Prtfw July 8, 2020 11:39
@cereallarceny cereallarceny merged commit 748db97 into master Jul 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/migrate-to-tfjs-plan branch July 9, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to TFJS-traslated plans
2 participants