-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for MNIST example tfjs translation #3802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vvmnnnkv If you update to 3p0 0.0.10 this should resolve the 2nd issue you mentioned |
@Nolski |
4 tasks
vvmnnnkv
added
Status: Review Needed 🙋
This needs someone to approve, deny, comment, or request changes
Type: Improvement 📈
Minor improvements not introducing a new feature or requiring a major refactor
Type: Testing 🧪
Add testing or improving existing testing of a file, feature, or codebase
labels
Jul 8, 2020
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #3802 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 186 186
Lines 18857 18868 +11
=======================================
+ Hits 17928 17939 +11
Misses 929 929
|
cereallarceny
approved these changes
Jul 8, 2020
Nilanshrajput
pushed a commit
to Nilanshrajput/PySyft
that referenced
this pull request
Jul 15, 2020
* Add unit test for MNIST example tfjs translation * Fix tfjs translation for mnist training example * Fix missing import * Update threepio dependency * Fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Review Needed 🙋
This needs someone to approve, deny, comment, or request changes
Type: Improvement 📈
Minor improvements not introducing a new feature or requiring a major refactor
Type: Testing 🧪
Add testing or improving existing testing of a file, feature, or codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit test that passes if MNIST example training Plan successfully translates to TFJS.
(It doesn't test correctness of translation, though, as it would require running JS engine with TFJS)
Affected Dependencies
This unit test should pass after these are merged:
.dim()
that can't be translated yet but not needed in training planHow has this been tested?
It's unit test on its own.
Checklist