Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dash symbols in combined symbols #2154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dl3sdo
Copy link
Member

@dl3sdo dl3sdo commented Apr 27, 2023

When drawing line objects for symbols with dash symbols, no dash points were set automatically if the symbol was a combined symbol.
When editing line objects for symbols with dash symbols, additional points were not added as dash points if the symbol was a combined symbol.
These deviations were known and marked as TODO.
This commit treats line symbols with dash symbols and combined symbols containing line symbols with dash symbols equally.

@dl3sdo dl3sdo force-pushed the dash-points-combined-symbols branch from 676d238 to 044165a Compare June 26, 2023 21:18
@dl3sdo dl3sdo mentioned this pull request Jun 27, 2023
@dg0yt dg0yt self-requested a review April 14, 2024 15:47
@dl3sdo dl3sdo force-pushed the dash-points-combined-symbols branch from 044165a to 165bf3d Compare August 22, 2024 12:43
* Function is used by DrawPathTool::updateDashPointDrawing() and
* EditPointTool::addDashPointDefault() in relation to setting and changing dash points.
*/
bool symbolContainsDashSymbol(const Symbol* symbol)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should become a virtual member function Symbol::containsDashSymbol, with suitable overrides in subclasses.

@dl3sdo dl3sdo marked this pull request as draft August 23, 2024 08:09
For line symbols and combined symbols determine if the symbol contains
a dash symbol.
When drawing line objects for symbols with dash symbols, no dash
points were set automatically if the symbol was a combined symbol.
When editing line objects for symbols with dash symbols, additional
points were not added as dash points if the symbol was a combined
symbol.
These deviations were known and marked as TODO.
This change treats line symbols with dash symbols and combined symbols
containing line symbols with dash symbols equally.
@dl3sdo dl3sdo force-pushed the dash-points-combined-symbols branch from 165bf3d to acaa4a5 Compare August 23, 2024 15:43
@dl3sdo dl3sdo marked this pull request as ready for review August 23, 2024 15:45
@dl3sdo
Copy link
Member Author

dl3sdo commented Sep 27, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@OpenOrienteering OpenOrienteering deleted a comment from azure-pipelines bot Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants