Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dash point by on default #1961

Open
mlerjen opened this issue May 27, 2021 · 1 comment · May be fixed by #2157
Open

Dash point by on default #1961

mlerjen opened this issue May 27, 2021 · 1 comment · May be fixed by #2157

Comments

@mlerjen
Copy link
Contributor

mlerjen commented May 27, 2021

(I had this problem before, #1728)

Steps to reproduce

  1. Draw a line - dash point "purple dot" is on.
  2. Draw a second line - switch off dash point by pressing space bar
  3. Draw a third line - dash point still off. Normal points are set.
  4. Draw another line object.
  5. Draw a fourth line with the first object - dash point is on again.
    image

Actual behaviour

So dash point is the default. It can be switched off as long as you stick with drawing features of the same symbol, but jumps back to default = dash point as soon you draw something else.

Expected behaviour

The dash point as the exception should be opt-in, but not default.

Configuration

Mapper Version: 0.9.5
Operating System: windows 7

@dl3sdo
Copy link
Member

dl3sdo commented Apr 27, 2023

Yes, this is indeed the current behaviour.
For combined symbols there was some functionality missing which I added as PR #2154, i.e., for combined
symbols the current behaviour is as the one proposed by @mlerjen as default behaviour.

Changing the default behaviour for line symbols with dash symbols and combined symbols with dash symbols to opt-in is straightforward.
However, this could also be made configurable by using an additional 'lightweight' configuration mechanism (which I'm currently working on).

dl3sdo added a commit to dl3sdo/mapper that referenced this issue May 22, 2023
Use JSON configuration to enable or disable the automatic setting
of dash points for symbols with dash symbols.
Closes OpenOrienteering#1961
@dl3sdo dl3sdo linked a pull request May 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants