Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bardeen Privacy Policy #196

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

OTA-Bot
Copy link
Contributor

@OTA-Bot OTA-Bot commented Jul 3, 2024

🔎 Inspect this declaration update suggestion

Bots should take care of checking the formatting and the validity of the declaration. As a human reviewer, you should check:

  • Selectors are:
    • stable: as much as possible, the CSS selectors are meaningful and specific (e.g. .tos-content rather than .ab23 .cK_drop > div).
    • simple: the CSS selectors do not have unnecessary specificity (e.g. if there is an ID, do not add a class or a tag).
  • Generated version is:
    • relevant: it is not just a series of links, for example.
    • readable: it is complete and not mangled.
    • clean: it does not contain navigation links, unnecessary images, or extra content.
  • validUntil date is correctly input in the history file. To get that date, you can use the following method. In all cases where a date is to be obtained from the GitHub user interface, you can obtain the exact datetime by hovering your cursor over the date or using the developer tools to copy its datetime attribute.
    1. Find the date at which the problem was first encountered:
    • If there is one, find the first date at which an issue was opened claiming that the terms can not be tracked anymore.
    • If there is no issue, or if the version is wrong even though the terms can be extracted, find the first version with wrong data and obtain its date.
    • If the document can not be fetched anymore, find the latest snapshot.
    1. Find the most recent snapshot that is strictly anterior to this date from the snapshots database.
    2. Set the creation date of this snapshot as the validUntil date in the history file.

Thanks to your work and attention, Open Terms Archive will ensure that high quality data is available for all reusers, enabling them to do their part in shifting the balance of power towards end users and regulators instead of spending time collecting and cleaning documents 💪


This update suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.

@MattiSG MattiSG requested a review from clementbiron July 3, 2024 15:50
"select": [
".content-text"
],
"validUntil": "2024-07-03T06:30:00Z"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you get this validUntildate?
Following our documentation i find 2024-07-03T06:30:07Z

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My copy-pasting mangled the last digits for some reason and I just thought the seconds don't really matter… If you think it's important that it matches, okay to make it match!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that worries me about this value being exact is the fact that it could have an impact in the case of a history rewrite, but I'm not clear enough on how this could or could not be important.

@clementbiron clementbiron merged commit c7cbe01 into main Jul 8, 2024
3 checks passed
@clementbiron clementbiron deleted the update_bardeen_privacy_policy branch July 8, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants