Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bardeen Privacy Policy #196

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Update Bardeen Privacy Policy #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f39a413
Update Bardeen Privacy Policy declaration
MattiSG Jul 3, 2024
c5e8d1e
Update Bardeen Privacy Policy history
MattiSG Jul 3, 2024
96e7f43
Update Bardeen.history.json
MattiSG Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions declarations/Bardeen.history.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"Privacy Policy": [
{
"fetch": "https://www.bardeen.ai/privacy-policy",
"select": [
".content-text"
],
"validUntil": "2024-07-03T06:30:00Z"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you get this validUntildate?
Following our documentation i find 2024-07-03T06:30:07Z

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My copy-pasting mangled the last digits for some reason and I just thought the seconds don't really matter… If you think it's important that it matches, okay to make it match!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that worries me about this value being exact is the fact that it could have an impact in the case of a history rewrite, but I'm not clear enough on how this could or could not be important.

}
]
}
2 changes: 1 addition & 1 deletion declarations/Bardeen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"Privacy Policy": {
"fetch": "https://www.bardeen.ai/privacy-policy",
"select": [
".content-text"
".content-container"
]
}
}
Expand Down
Loading