-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic multisig Account #21
Comments
One possible implementation can be found in argent's account contract. It performs each check separately, which is basically the same logic but for a privileged signer.
|
@martriay may i work on this issue? |
Really appreciate the energy! But let's focus on closing the other PRs first :) |
@martriay hi, tell me when we're good to start working on this feature, if no one else is working on it yet :) |
sure! although i believe this one is a bit heavy on design, so i would focus on that way before opening any full implementation PR -- of course it makes sense to fiddle around with code while designing, just a warning on not overdoing it like tests or full implementations if we notice it's a bad design path |
some challenges i foresee here is having a different storage struct due to having multiple and not a single owner as our current designs, and how to manage the code duplication if we were to have two different components, etc |
This should be implemented in the
is_valid_signature
function.This is how it looks for single signature accounts:
The text was updated successfully, but these errors were encountered: