Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add basic Multisig Account #924

Closed
wants to merge 5 commits into from

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Feb 23, 2024

Fixes #21

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

@TAdev0
Copy link
Contributor Author

TAdev0 commented Feb 23, 2024

@martriay this is a first draft, only spent 2 hours on it.

Basically, i modified :

  • get_public_key for get_public_keys , returning a span of all public keys stored associated with the account
  • set_public_key for add_public_key and remove_public_key (with some checks missing for now)
  • _is_valid_signature now makes sure that all provided sig are valid

It is just a draft so you can tell me if the way i implemented it is relevant or not.
Not that i added a threshold variable in storage, but did not implement for now a way to set it and modify it.

@martriay
Copy link
Contributor

Thanks! Will look into it after we finish the current release.

@ericnordelo
Copy link
Member

Hey @TAdev0, thanks for taking the time to contribute. Since we delayed this issue for a while, we worked on an implementation that will be included in this release. Feel free to jump into the conversation on #1193.

@ericnordelo ericnordelo closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic multisig Account
3 participants