Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate UDC to Cairo 1+ #552

Closed
martriay opened this issue Jan 28, 2023 · 4 comments · Fixed by #919
Closed

Migrate UDC to Cairo 1+ #552

martriay opened this issue Jan 28, 2023 · 4 comments · Fixed by #919
Assignees

Comments

@martriay
Copy link
Contributor

martriay commented Jan 28, 2023

No description provided.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cairo team Jan 28, 2023
@martriay martriay added this to the next milestone Jan 28, 2023
@martriay martriay moved this to 📋 Backlog in Contracts for Cairo Feb 16, 2023
@martriay martriay modified the milestones: next, after, later Mar 15, 2023
@martriay martriay modified the milestones: after, next Mar 31, 2023
This was referenced Apr 18, 2023
@martriay martriay moved this from 📋 Backlog to 👀 In review in Contracts for Cairo Apr 24, 2023
@martriay martriay moved this from 👀 In review to 🏗 In progress in Contracts for Cairo Apr 24, 2023
@martriay martriay modified the milestones: next, current Apr 24, 2023
@martriay martriay linked a pull request Apr 28, 2023 that will close this issue
3 tasks
@martriay martriay modified the milestones: current, next May 22, 2023
@martriay martriay changed the title Migrate UDC & utils Migrate UDC Nov 22, 2023
@martriay martriay changed the title Migrate UDC Migrate UDC to Cairo 1+ Nov 22, 2023
@martriay martriay modified the milestones: later, after Nov 24, 2023
@martriay martriay added this to the later milestone Dec 10, 2023
@FabijanC
Copy link

Any plans to resolve this? Revive #610?
cc: @mikiw

@martriay
Copy link
Contributor Author

martriay commented Jan 24, 2024

This is planned as part of the "later" milestone, which usually means it's roughly between 9 to 12 weeks away -- in all honesty, this is not always true since we periodically reassess priorities and milestones and stuff might get deprioritized (new issues arise, some others take longer, etc.) so it's not a super strong commitment for you to plan on top of.

That being said, the UDC was blocked until not long ago because of lacking testing framework capabilities, specifically around deployment address differences between mainnet and test framework, which should be resolved as of now.
More generally, the UDC was never a priority in the Cairo 1+ migration due to the Cairo 0 version working just fine, and since this is a singleton deployment and not a developer dependency. Regenesis is the only deadline we have, and its date is uncertain.

Do you need this before? May I ask why? Better understanding your needs will help us inform better and prioritize our roadmap.

@martriay martriay modified the milestones: later, after Jan 26, 2024
@FabijanC
Copy link

Thanks for the reply!

Starkware was planning on using starknet-devnet-rs for their testing simulation, and asked us to update the predeployed ERC20 and accounts to Cairo 1. Devnet already offers OZ Cairo 1 accounts, but not by default.

Anyway, I was thinking of completely switching all predeployed contracts to Cairo 1, which would mean only UDC remains.

@martriay
Copy link
Contributor Author

Thanks for providing more context. I'll make sure to keep you updated on this one.

@andrew-fleming andrew-fleming mentioned this issue Feb 19, 2024
4 tasks
@martriay martriay modified the milestones: later, after, current Mar 4, 2024
@martriay martriay moved this from 🏗 In progress to 👀 In review in Contracts for Cairo Mar 4, 2024
@martriay martriay moved this from 👀 In review to 🏗 In progress in Contracts for Cairo Mar 4, 2024
@andrew-fleming andrew-fleming moved this from 🏗 In progress to 👀 In review in Contracts for Cairo Mar 7, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Resolved in Contracts for Cairo Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Resolved
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants