Migrate udc #610
Closed
Migrate udc #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
reviewed
Apr 19, 2023
src/openzeppelin/utils/udc.cairo
Outdated
| // TODO: Fix trait impl errors in abi | ||
| // #[abi] | ||
| trait IUniversalDeployerContract { | ||
| #[event] |
There was a problem hiding this comment.
can you do these modifiers on traits like this?
i haven't seen that anywhere else yet.
There was a problem hiding this comment.
Yeah, you can and the contracts compile. The external and view macros might be redundant, but I assume we'll need to include it for event (so other contracts aren't required to reimplement the event in an impl). Here's a test data example from the Cairo repo: https://github.com/starkware-libs/cairo/blob/main/crates/cairo-lang-starknet/src/plugin/plugin_test_data/dispatcher#L6-L17
Closed
martriay
reviewed
May 10, 2023
Co-authored-by: Martín Triay <martriay@gmail.com>
|
This PR got closed by mistake automatically after deleting the |
martriay
reviewed
Dec 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (partial) #552.
WIP. Still needs tests.
Note: the cairo submodule is bumped to starkware-libs/cairo@3eb7c83 (above alpha7) in order to include a bug fix for inconsistent references annotations. Otherwise, the runner won't set up properly.
PR Checklist