Migrate UDC #919
Migrate UDC #919
Conversation
src/presets/universal_deployer.cairo
Outdated
| let mut from_zero: bool = true; | ||
|
|
||
| if unique { | ||
| _salt = pedersen(deployer.into(), salt); |
There was a problem hiding this comment.
Should we consider using poseidon since is much cheaper? Maybe a UDC_v2?
There was a problem hiding this comment.
Huge +1 to UDC_v2 with poseidon
There was a problem hiding this comment.
+1, but note this UDC is already v2
There was a problem hiding this comment.
I think we may need to be explicit in the name regarding the version. If people are using UDC already to predict addresses before deployment, getting confused about whether it uses pedersen or poseidon could be problematic, since the addresses would be different.
There was a problem hiding this comment.
Should we update to Poseidon then on this PR? And should we add documentation about it and versions? In the starknet docsite we are not for example mentioning which hash algorithm is used, or how to precompute the addresses, and I think that's worth to mention.
There was a problem hiding this comment.
Made this an issue: #950
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
| assert_eq!(expected_addr, deployed_addr); | ||
|
|
||
| // Check event | ||
| let event = utils::pop_log::<UniversalDeployer::Event>(udc.contract_address).unwrap(); |
There was a problem hiding this comment.
Should we move this into a helper for consistency?
src/presets/universal_deployer.cairo
Outdated
| let mut from_zero: bool = true; | ||
|
|
||
| if unique { | ||
| _salt = pedersen(deployer.into(), salt); |
There was a problem hiding this comment.
I think we may need to be explicit in the name regarding the version. If people are using UDC already to predict addresses before deployment, getting confused about whether it uses pedersen or poseidon could be problematic, since the addresses would be different.
src/presets/universal_deployer.cairo
Outdated
| let mut from_zero: bool = true; | ||
|
|
||
| if unique { | ||
| _salt = pedersen(deployer.into(), salt); |
There was a problem hiding this comment.
Should we update to Poseidon then on this PR? And should we add documentation about it and versions? In the starknet docsite we are not for example mentioning which hash algorithm is used, or how to precompute the addresses, and I think that's worth to mention.
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
Co-authored-by: Martín Triay <martriay@gmail.com>
Co-authored-by: Martín Triay <martriay@gmail.com>
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
Fixes #552.
PR Checklist