Remove account dual dispatchers #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## remove-dual-dispatchers #1168 +/- ##
==========================================================
Coverage ? 89.66%
==========================================================
Files ? 53
Lines ? 1316
Branches ? 0
==========================================================
Hits ? 1180
Misses ? 136
Partials ? 0
Continue to review full report in Codecov by Sentry.
|
|
There are also |
Those are removed in #1175 |
…ro-contracts into feat/remove-account-dual-dispatchers
ericnordelo
merged commit b8a3ed5
into
OpenZeppelin:remove-dual-dispatchers
2 checks passed
ericnordelo
added a commit
that referenced
this pull request
Oct 7, 2024
* feat: remove access dual dispatchers (#1154) * feat: remove account dual dispatchers (#1168) * Remove token dual dispatchers (#1175) * feat: remove modules * fix: mock * fix: linter * fix: tests * fix: mock * feat: apply review suggestions * feat: fix import * Remove dual dispatchers docs and CHANGELOG (#1177) * feat: update docs * feat: update CHANGELOG * fix: typo * fix: mod * feat: remove unused imports * fix: README * feat: remove selectors * Update docs/modules/ROOT/pages/interfaces.adoc Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * feat: add mention and link to dispatcher types * feat: remove import * Update docs/modules/ROOT/pages/interfaces.adoc Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * fix: README --------- Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> --------- Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
ericnordelo
added a commit
that referenced
this pull request
Oct 8, 2024
* feat: add features * feat: remove access dual dispatchers (#1154) * feat: bump scarb * feat: update CHANGELOG * feat: add features * feat: remove account dual dispatchers (#1168) * feat: move mocks to test_common * Remove token dual dispatchers (#1175) * feat: remove modules * fix: mock * fix: linter * fix: tests * fix: mock * feat: apply review suggestions * feat: update docs * feat: update CHANGELOG * fix: typo * fix: mod * feat: remove unused imports * fix: README * feat: move mocks into test_common * feat: remove mocks from release target * fix: mock * fix: imports * feat: bumo scarb and remove assert_macros from manifest * feat: re-add assert_macros * feat: add test target names * docs: update index
ericnordelo
added a commit
that referenced
this pull request
Nov 20, 2024
* feat: add features * feat: remove access dual dispatchers (#1154) * feat: bump scarb * feat: update CHANGELOG * feat: add features * feat: remove account dual dispatchers (#1168) * feat: move mocks to test_common * Remove token dual dispatchers (#1175) * feat: remove modules * fix: mock * fix: linter * fix: tests * fix: mock * feat: apply review suggestions * feat: update docs * feat: update CHANGELOG * fix: typo * fix: mod * feat: remove unused imports * fix: README * feat: move mocks into test_common * feat: remove mocks from release target * fix: mock * fix: imports * feat: bumo scarb and remove assert_macros from manifest * feat: re-add assert_macros * feat: add test target names * docs: update index * feat: add interface * feat: add double ended queue struct * feat: add proposal core * + * feat: add extension traits * feat: add hash_proposal * feat: add state internal function * feat: add bytearray to utils * fix: bytearray trait types * feat: apply stash * feat: add propose mechanism * feat: add queue mechanism * feat: add execute and cancel * feat: add main trait * feat: finish first extension * feat: add votes quorum fractional extension main logic * feat: add settings extension * feat: add governor votes extension * feat: add core execution extension * feat: add timelock execution extension * refactor: dependencies * feat: add mock * fix: linter * fix: comment * feat: add some tests * fix: linter * refactor: comments * fix: import path * fix: test * feat: add relay mechanism * fix: conditions * feat: add more tests * fix: linter * feat: add more tests * feat: add more tests * Update packages/governance/src/governor/interface.cairo Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * Update packages/governance/src/governor/interface.cairo Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * Update packages/governance/src/governor/governor.cairo Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * Update packages/governance/src/governor/governor.cairo Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * Update packages/governance/src/governor/governor.cairo Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * Update packages/governance/src/governor/proposal_core.cairo Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * feat: apply review updates * fix: linter * fix: bytearray * feat: add more tests * feat: add more tests * Update packages/utils/src/bytearray.cairo Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com> * feat: apply review updates * feat: add cast vote by sig * feat: add more tests * feat: add more tests * fix: remove import * feat: add yet more tests * feat: update CHANGELOG * feat: apply review updates * feat: add tests for governor core execution * feat: add more tests * feat: add more tests * feat: add more tests * fix: linter * feat: add more tests * feat: add more tests * feat: add more tests * fix: warnings * feat: add more tests * feat: add more tests * fix: linter --------- Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1128