Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove token dual dispatchers #1175

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Remove token dual dispatchers #1175

merged 7 commits into from
Oct 3, 2024

Conversation

ericnordelo
Copy link
Member

Partially fixes #1128

@ericnordelo ericnordelo mentioned this pull request Oct 2, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (8ef6a41) to head (03ecad0).
Report is 4 commits behind head on remove-dual-dispatchers.

Additional details and impacted files 
@@                     Coverage Diff                     @@
##           remove-dual-dispatchers    #1175      +/-   ##
===========================================================
+ Coverage                    88.87%   91.51%   +2.63%     
===========================================================
  Files                           57       46      -11     
  Lines                         1375     1178     -197     
===========================================================
- Hits                          1222     1078     -144     
+ Misses                         153      100      -53
Files with missing lines Coverage Δ
packages/token/src/erc1155/erc1155.cairo 98.96% <100.00%> (ø)
packages/token/src/erc721/erc721.cairo 90.24% <100.00%> (-0.82%) ⬇️

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6a41...03ecad0. Read the comment docs.

andrew-fleming
andrew-fleming reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks mostly good to go. Just left some questions

packages/presets/src/lib.cairo Outdated Show resolved Hide resolved
packages/presets/src/tests/mocks/erc1155_receiver_mocks.cairo Outdated Show resolved Hide resolved
packages/presets/src/tests.cairo Outdated Show resolved Hide resolved
packages/presets/src/tests/test_erc721.cairo Show resolved Hide resolved
packages/token/src/tests/erc1155/test_erc1155.cairo Show resolved Hide resolved
packages/token/src/tests/erc721/test_erc721.cairo Show resolved Hide resolved
andrew-fleming
andrew-fleming approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericnordelo ericnordelo merged commit 094081c into OpenZeppelin:remove-dual-dispatchers Oct 3, 2024
4 checks passed
@ericnordelo ericnordelo deleted the feat/remove-token-dual-dispatchers-2 branch October 3, 2024 23:31
ericnordelo added a commit that referenced this pull request Oct 7, 2024
@ericnordelo @andrew-fleming
Remove DualCase dispatchers (#1163)
805e9cb 
* feat: remove access dual dispatchers (#1154)

* feat: remove account dual dispatchers (#1168)

* Remove token dual dispatchers (#1175)

* feat: remove modules

* fix: mock

* fix: linter

* fix: tests

* fix: mock

* feat: apply review suggestions

* feat: fix import

* Remove dual dispatchers docs and CHANGELOG (#1177)

* feat: update docs

* feat: update CHANGELOG

* fix: typo

* fix: mod

* feat: remove unused imports

* fix: README

* feat: remove selectors

* Update docs/modules/ROOT/pages/interfaces.adoc

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>

* feat: add mention and link to dispatcher types

* feat: remove import

* Update docs/modules/ROOT/pages/interfaces.adoc

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>

* fix: README

---------

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>

---------

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
ericnordelo added a commit that referenced this pull request Oct 8, 2024
@ericnordelo
Improve mocks (#1146)
1cbef43 
* feat: add features

* feat: remove access dual dispatchers (#1154)

* feat: bump scarb

* feat: update CHANGELOG

* feat: add features

* feat: remove account dual dispatchers (#1168)

* feat: move mocks to test_common

* Remove token dual dispatchers (#1175)

* feat: remove modules

* fix: mock

* fix: linter

* fix: tests

* fix: mock

* feat: apply review suggestions

* feat: update docs

* feat: update CHANGELOG

* fix: typo

* fix: mod

* feat: remove unused imports

* fix: README

* feat: move mocks into test_common

* feat: remove mocks from release target

* fix: mock

* fix: imports

* feat: bumo scarb and remove assert_macros from manifest

* feat: re-add assert_macros

* feat: add test target names

* docs: update index
ericnordelo added a commit that referenced this pull request Nov 20, 2024
@ericnordelo @andrew-fleming @immrsd
Add Governor component (#1180)
f0edfaa 
* feat: add features

* feat: remove access dual dispatchers (#1154)

* feat: bump scarb

* feat: update CHANGELOG

* feat: add features

* feat: remove account dual dispatchers (#1168)

* feat: move mocks to test_common

* Remove token dual dispatchers (#1175)

* feat: remove modules

* fix: mock

* fix: linter

* fix: tests

* fix: mock

* feat: apply review suggestions

* feat: update docs

* feat: update CHANGELOG

* fix: typo

* fix: mod

* feat: remove unused imports

* fix: README

* feat: move mocks into test_common

* feat: remove mocks from release target

* fix: mock

* fix: imports

* feat: bumo scarb and remove assert_macros from manifest

* feat: re-add assert_macros

* feat: add test target names

* docs: update index

* feat: add interface

* feat: add double ended queue struct

* feat: add proposal core

* +

* feat: add extension traits

* feat: add hash_proposal

* feat: add state internal function

* feat: add bytearray to utils

* fix: bytearray trait types

* feat: apply stash

* feat: add propose mechanism

* feat: add queue mechanism

* feat: add execute and cancel

* feat: add main trait

* feat: finish first extension

* feat: add votes quorum fractional extension main logic

* feat: add settings extension

* feat: add governor votes extension

* feat: add core execution extension

* feat: add timelock execution extension

* refactor: dependencies

* feat: add mock

* fix: linter

* fix: comment

* feat: add some tests

* fix: linter

* refactor: comments

* fix: import path

* fix: test

* feat: add relay mechanism

* fix: conditions

* feat: add more tests

* fix: linter

* feat: add more tests

* feat: add more tests

* Update packages/governance/src/governor/interface.cairo

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>

* Update packages/governance/src/governor/interface.cairo

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>

* Update packages/governance/src/governor/governor.cairo

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>

* Update packages/governance/src/governor/governor.cairo

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>

* Update packages/governance/src/governor/governor.cairo

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>

* Update packages/governance/src/governor/proposal_core.cairo

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>

* feat: apply review updates

* fix: linter

* fix: bytearray

* feat: add more tests

* feat: add more tests

* Update packages/utils/src/bytearray.cairo

Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>

* feat: apply review updates

* feat: add cast vote by sig

* feat: add more tests

* feat: add more tests

* fix: remove import

* feat: add yet more tests

* feat: update CHANGELOG

* feat: apply review updates

* feat: add tests for governor core execution

* feat: add more tests

* feat: add more tests

* feat: add more tests

* fix: linter

* feat: add more tests

* feat: add more tests

* feat: add more tests

* fix: warnings

* feat: add more tests

* feat: add more tests

* fix: linter

---------

Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-fleming andrew-fleming andrew-fleming approved these changes

@immrsd immrsd Awaiting requested review from immrsd

@ggonzalez94 ggonzalez94 Awaiting requested review from ggonzalez94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericnordelo @andrew-fleming