Fix gas report generation

[Amxx]

Gas report generaton has been broken for a while.
It looks like the json file is no longer generated by default. Adding an envvar should fix that.

WIP: multiple issues have been identified and are being worked on.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3192dd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @nomicfoundation/hardhat-toolbox@4.0.0

[Amxx]

This should work.
@ernestognw, how do you feel about hre.getSigners as a replacement for hre.ethers.getSigners ?

[ernestognw]

This should work.
@ernestognw, how do you feel about hre.getSigners as a replacement for hre.ethers.getSigners ?

I like the idea and looks very clean, but I don't like that it's implicit (e.g. is not obvious for a contributor). I need to review first to fully understand the changes. I think it's fine but not preferrable.

[Amxx]

Removed env-contracts.js that was not working as intended anyway. Will create an issue to consider re-implementing this mechanism.

[ernestognw]

Pretty weird it's not working as expected. I'll take a look to understand what's going on here. We shouldn't merge it if we're misinterpreting how it works.

Otherwise, we may remove the implies.

[ernestognw]

LGTM but I see the runnings are still not producing the gas comparison. Is it because it's not merged yet?

[Amxx]

LGTM but I see the runnings are still not producing the gas comparison. Is it because it's not merged yet?

Yes, gas reports produced by PR are not pushed, because nothing is going to be compared to that.
We save the reports for commits on branches that will be references for further PR.