Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run gas-compare action on push to master #4834

Merged

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented Jan 13, 2024

After #4824, the #4822 PR was synced. However, it is still not producing the gas comparison because the report from master is not executed given github.base_ref is empty when a commit triggered the run. In that case, the master report is just skipped.

With this change, we'll be running the comparison only in commits to master and pull requests targeting to master

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Jan 13, 2024

⚠️ No Changeset found

Latest commit: 1eff419

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw mentioned this pull request Jan 13, 2024
3 tasks
.github/workflows/checks.yml Outdated Show resolved Hide resolved
@ernestognw ernestognw requested a review from Amxx January 15, 2024 18:07
@Amxx Amxx merged commit 281ab15 into OpenZeppelin:master Jan 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants