-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process and verify merkle proofs (and multiproof) with custom hash function #4887
Process and verify merkle proofs (and multiproof) with custom hash function #4887
Conversation
🦋 Changeset detectedLatest commit: b7d56bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some nits but the PR looks good imo. It may just need to be tested with custom hashing functions but that can't be done until we release the merkle tree library.
I'd be fine leaving an issue and merging, wdyt @Amxx? I see codecov was flagging a drop in coverage. Investigating both #4977 and this drop
b85551a
to
9c7ab66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a TODO for when we release the Typescript library
…to feature/cryptography/merkle-proof-custom-hash
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@openzeppelin/merkle-tree@1.0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the tests with the new Merkle Tree release.
LGTM
Fixes #4886
The hasher should be view, but the existing versions are pure. This is resulved by
This large amount of code duplication is handled through procedural generation
npx changeset add
)