Get leaves from memory in processMultiProofCalldata

[Amxx]

Following the audit discussion.

Note that is reverting a (undocumented breaking) change that we introduced in #4887
5.0 does use memory for leaves in the calldata variants:

• https://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v5.0/contracts/utils/cryptography/MerkleProof.sol#L88-L95
• https://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v5.0/contracts/utils/cryptography/MerkleProof.sol#L88-L95

Edit: I also took this opportunity to fix some missing {suffix} in the code generation.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 250325d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ernestognw]

Looks good, but I'm wondering whether it's still useful to have the following two versions:

function multiProofVerifyCalldata(
    bytes32[] calldata proof,
    bool[] calldata proofFlags,
    bytes32 root,
    bytes32[] calldata leaves,
    function(bytes32, bytes32) view returns (bytes32) hasher
) internal view returns (bool) {
    return processMultiProofCalldata(proof, proofFlags, leaves, hasher) == root;
}

function multiProofVerifyCalldata(
    bytes32[] calldata proof,
    bool[] calldata proofFlags,
    bytes32 root,
    bytes32[] calldata leaves
) internal pure returns (bool) {
    return processMultiProofCalldata(proof, proofFlags, leaves) == root;
}

They seem rather unnecessary given that we're copying leaves to memory when using the underlying processMultiProof

[Amxx]

Right, I forgot about the leaves location in multiProofVerifyCalldata. Fixed.

[ernestognw]

Thanks @Amxx