Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): get back unboxingFlow path update function #16411

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(app): get back unboxingFlow path update function #16411

merged 1 commit into from
Oct 3, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Oct 3, 2024 •
edited
Loading

Overview

the details here.

close RQA-3271

Test Plan and Hands on Testing

  1. flash an image
  2. do unboxing flow
  3. tap any item in navigation
    check 2 things
  • the welcome modal isn't shown up
  • /data/ODD/config.json "unfinishedUnboxingFlowRoute": null

Changelog

Review requests

Risk assessment

low

@koji koji requested a review from vegano1 October 3, 2024 18:58
@koji koji changed the base branch from edge to chore_release-8.1.0 October 3, 2024 18:59
@koji koji requested review from mjhuff and ncdiehl11 October 3, 2024 18:59
@koji koji marked this pull request as ready for review October 3, 2024 19:04
@koji koji requested a review from a team as a code owner October 3, 2024 19:04
vegano1
vegano1 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 nice job!
thank you

@koji koji removed the request for review from a team October 3, 2024 19:08
@koji koji merged commit 4bca02a into chore_release-8.1.0 Oct 3, 2024
14 checks passed
@koji koji deleted the fix_RQA-3271 branch October 3, 2024 19:18
y3rsh pushed a commit that referenced this pull request Oct 7, 2024
@koji @y3rsh
fix(app): get back unboxingFlow path update function (#16411)
c443f59 
* fix(app): get back unboxingFlow path update function
@y3rsh y3rsh mentioned this pull request Oct 7, 2024
Merged
1 task
y3rsh added a commit that referenced this pull request Oct 7, 2024
@y3rsh @koji
fix(app): get back unboxingFlow path update function (#16411) (#16428)
d1de808 
## Cherry-pick 4bca02a #16411 

- [ ] Reviewer please validate that I resolved the conflicts correctly
as edge has the import pathing updates.

Co-authored-by: koji <koji.kanao@opentrons.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegano1 vegano1 vegano1 approved these changes

@mjhuff mjhuff Awaiting requested review from mjhuff

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koji @vegano1