Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): use move flags in aionotify for modules #14345

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

sfoster1
Copy link
Member

After updating openembedded and buildroot, their udevs will actually create temporary files for module serial port symlinks and then rename the tempfiles to the real thing. This wouldn't get noticed because they were moves, rather than creates or deletes. Getting aionotify to tell us about moves too and plumbing those events through the add/delete paths fixes the issue.

Closes RQA-2240

After updating openembedded and buildroot, their udevs will actually
create temporary files for module serial port symlinks and then rename
the tempfiles to the real thing. This wouldn't get noticed because they
were moves, rather than creates or deletes. Getting aionotify to tell us
about moves too and plumbing those events through the add/delete paths
fixes the issue.

Closes RQA-2240
@sfoster1 sfoster1 requested a review from a team January 24, 2024 16:47
@sfoster1 sfoster1 requested a review from a team as a code owner January 24, 2024 16:47
@sfoster1 sfoster1 merged commit 46195f5 into edge Jan 24, 2024
27 checks passed
@sfoster1 sfoster1 deleted the rqa-2240-fix-module-detection branch January 24, 2024 19:11
ncdiehl11 pushed a commit that referenced this pull request Feb 1, 2024
After updating openembedded and buildroot, their udevs will actually
create temporary files for module serial port symlinks and then rename
the tempfiles to the real thing. This wouldn't get noticed because they
were moves, rather than creates or deletes. Getting aionotify to tell us
about moves too and plumbing those events through the add/delete paths
fixes the issue.

Closes RQA-2240
sanni-t added a commit that referenced this pull request May 8, 2024
)

Closes AUTH-379

# Overview

#14345 updated the module ports filtering to exclude any temporary ports
created by udev. But the regex used for port name matching filters out
only Flex port names (e.g. `ot_module_thermocycler2.tmp-c166:2`). This
PR adds regex to filter out OT-2 temp ports as well (e.g.
`.#ot_module_thermocycler0b494617b5e4f08ae`).

# Risk assessment

Medium. Can affect module connectivity but is easy to test and rule out
any issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants