fix(api): do not include HEPA-UV in motor nodes #14478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14478 +/- ##
====================================================
Coverage 67.78% 67.78%
====================================================
Files 2519 2519
Lines 72012 72012
Branches 9263 9263
====================================================
Hits 48814 48814
Misses 20991 20991
Partials 2207 2207
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vegano1
approved these changes
Feb 12, 2024
| @@ -351,8 +351,13 @@ def motor_nodes(devices: Set[FirmwareTarget]) -> Set[NodeId]: | |||
| NodeId.head_bootloader, | |||
| NodeId.gripper_bootloader, | |||
| } | |||
| hepa_nv_nodes = { | |||
There was a problem hiding this comment.
lol yep u != n, who would have thought
sfoster1
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We should exclude hepa uv and its bootloader node from the motor nodes, so we don't get a timeout response fetching motor position from them.