fix(robot-server): append error to analysis error list in case an internal error occurred

[TamarZanzouri]

Overview

closes RSS-169.
append internal error to analysis errors list in case a un expected error occured.

Test Plan

Tested this by adding a raise in the runner.run method. made sure that the analysis is not stuck in a pending state.
Can do the same test on a robot.
Make sure analysis completed with "NOT_OK" result and that the error appears.

{
    "data": [
        {
            "id": "45aeefdd-8450-470d-8289-bde0d6c17597",
            "status": "completed",
            "result": "not-ok",
            "robotType": "OT-2 Standard",
            "commands": [],
            "labware": [],
            "pipettes": [],
            "modules": [],
            "liquids": [],
            "errors": [
                {
                    "id": "internal-error",
                    "createdAt": "2024-02-16T02:24:08.423768+00:00",
                    "errorCode": "4000",
                    "errorType": "PythonException",
                    "detail": "RuntimeError: No active exception to reraise",
                    "errorInfo": {
                        "args": "('No active exception to reraise',)",
                        "traceback": "  File \"/Users/tamarzanzouri/opentrons/robot-server/robot_server/protocols/protocol_analyzer.py\", line 37, in analyze\n    result = await runner.run(\n\n  File \"/Users/tamarzanzouri/opentrons/api/src/opentrons/protocol_runner/protocol_runner.py\", line 307, in run\n    raise\n",
                        "class": "RuntimeError"
                    },
                    "wrappedErrors": []
                }
            ]
        }
    ],
    "meta": {
        "cursor": 0,
        "totalLength": 1
    }
}

Changelog

• Added a "catch all" for errors that the PE does not catch internally in analyze.
• Create an error from the internal error and append it to the analysis error list.

Risk assessment

low.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2978c7) 67.76% compared to head (832b783) 67.76%.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           chore_release-7.2.0   #14510   +/-   ##
====================================================
  Coverage                67.76%   67.76%           
====================================================
  Files                     2517     2517           
  Lines                    72054    72054           
  Branches                  9276     9276           
====================================================
  Hits                     48828    48828           
  Misses                   21008    21008           
  Partials                  2218     2218           

Flag	Coverage Δ
app	64.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...server/robot_server/protocols/protocol_analyzer.py	100.00% <ø> (ø)

[SyntaxColoring]

Looks good, just a few small suggestions. Thank you!

[sfoster1]

Looks good to me, couple tiny fixes maybe

[sanni-t]

Looks like there was some rebasing mixup? Should rebase on top of chore_release-7.2.0.