test: 7.2.0 Analysis Snapshot Protocols

[DerekMaggio]

Overview

Add protocols pulled from v7.2.0 pull requests for Analysis Snapshot testing. All work filed under RQA-2434

Test Plan

• Add partial tip pickup protocols from Sanitti
• Add ABR protocol from RABR-23
• Run new protocols locally and verify results
• Run in workflow dispatch action and verify success [link]

Changelog

Here are the protocols added and where I found them:

• RQA-2098
  • Flex_P1000_96_Gripper_TC_TM_HS_AnalysisError_GripperCollisionWithTips.json
• fix(api): associate thermocycler with all slots it occupies #14491
  • Flex_None_None_TC_2_14_verifyThermocyclerLoadedSlots.py
  • Flex_None_None_TC_2_15_verifyThermocyclerLoadedSlots.py
  • Flex_None_None_TC_2_16_verifyThermocyclerLoadedSlots.py
  • Flex_None_None_TC_2_17_verifyThermocyclerLoadedSlots.py
  • OT2_None_None_TC_2_14_VerifyThermocyclerLoadedSlots.py
  • OT2_None_None_TC_2_15_VerifyThermocyclerLoadedSlots.py
  • OT2_None_None_TC_2_16_VerifyThermocyclerLoadedSlots.py
  • OT2_None_None_TC_2_17_VerifyThermocyclerLoadedSlots.py
• fix(api): OT-2 trash bins in 2.16 get added to engine at the start of protocol #14475
  • Flex_None_None_TC_2_16_AnalysisError_TrashBinAndThermocyclerConflict.py
  • OT2_None_None_2_16_verifyDoesNotDeadlock.py
  • OT2_None_None_HS_2_16_AnalysisError_HeaterShakerConflictWithTrashBin1.py
  • OT2_None_None_HS_2_16_AnalysisError_HeaterShakerConflictWithTrashBin2.py
• feat(api): add pipette outer dimensions when checking movement conflict #14547
  • Flex_P1000_96_None_TC_2_16_AnalysisError_pipetteCollisionWithThermocyclerLid.py
• feat(api): raise an error if pipette nozzles might collide with thermocycler lid clips #14522
  • Flex_P1000_96_None_TC_2_16_AnalysisError_pipetteCollisionWithThermocyclerLidClips.py
• Dispense functionality validation
  • OT2_P300M_P20S_TC_HS_TM_2_15_dispense_changes.py
  • OT2_P300M_P20S_TC_HS_TM_2_16_dispense_changes.py
  • OT2_P300M_P20S_TC_HS_TM_2_17_dispense_changes.py
• fix(api): Fix floating point errors and backwards incompatibility in volume validation #14253
  • OT2_P300S_None_2_16_verifyNoFloatingPointErrorInPipetting.py

Review requests

There are a few pull requests that I had questions about. I will @ the people that worked on them to answer the questions

• fix(api): home before retrieving gantry position for disengaged Z mounts in FLEX #14437
  • @sfoster1, Can I use the protocol found in RABR-23 to get this to happen? Is there another way?
• fix(robot-server): Fix error parsing persisted loadModule commands #14509
  • @SyntaxColoring, can analysis capture this change or is this only relavant during actual protocol runtime?
• fix(robot-server): append error to analysis error list in case an internal error occurred #14510
  • @TamarZanzouri or @SyntaxColoring, can I raise a generic python exception inside the protocol to trigger this functionality?
• refactor(api): Save and load tip length calibrations from tiprack uri #14512
  • @Laura-Danielle or @SyntaxColoring, Iant to validate my logic. This not a good canidate for snapshot testing because you have to run LPC and Calibration which is not taken into account during analysis. Can you confirm?

Risk assessment

None

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.50%. Comparing base (b533692) to head (5f0959b).

Additional details and impacted files

@@           Coverage Diff           @@
##             edge   #14569   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files        2514     2514           
  Lines       72375    72375           
  Branches     9317     9317           
=======================================
  Hits        48856    48856           
  Misses      21314    21314           
  Partials     2205     2205           

Flag	Coverage Δ
app	63.99% <ø> (ø)
components	48.40% <ø> (ø)
labware-library	41.11% <ø> (ø)
protocol-designer	37.90% <ø> (ø)
step-generation	86.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[sfoster1]

I'd expect you can use RABR-23 to test #14437 yeah

[SyntaxColoring]

• fix(robot-server): Fix error parsing persisted loadModule commands #14509

  • @SyntaxColoring, can analysis capture this change or is this only relavant during actual protocol runtime?

Analysis can't capture it. It's only relevant when robot-server retrieves details about runs and analyses stored from prior boots.

• fix(robot-server): append error to analysis error list in case an internal error occurred #14510

  • @TamarZanzouri or @SyntaxColoring, can I raise a generic python exception inside the protocol to trigger this functionality?

Unfortunately no. The hole that that PR plugged is only for exceptions raised by certain Opentrons internal code.

• refactor(api): Save and load tip length calibrations from tiprack uri #14512

  • @Laura-Danielle or @SyntaxColoring, Iant to validate my logic. This not a good canidate for snapshot testing because you have to run LPC and Calibration which is not taken into account during analysis. Can you confirm?

Yep, I agree. That fix is for robot runtime behavior, which we can't cover with these analysis tests. Theoretically, we could do a similar snapshot thing for robot runtime behavior. I guess that would be g-code-testing.

[SyntaxColoring]

Here are some possible apiLevel mistakes, but other than that, this looks great to me. Thank you!

[y3rsh]

One step to add in the README otherwise great.

[y3rsh]

Adding back into the test with this task https://opentrons.atlassian.net/browse/RDEVOPS-71

[y3rsh]

❤️ these comments.

[y3rsh]

Add the step to build the docker container since it must be built before running the test

TARGET="<target-branch-or-tag>" make build-opentrons-analysis