Opti develop update #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IFrameTarp.prototype.cover function calls `findPos` from the `dygraph-utils.js` file but does not import it. This fixes danvk#724
Bugfix: Import missing dygraph-utils.js
Extended list of users
Also includes a minor refactor to consolidate duplicated code for toDataCoord calculations on logscale axes. Fixes issue danvk#661.
Chart overlaps "Edit in jsFiddle" button
Fix yRangePad for logscale graphs, add tests.
Add new issue and PR templates
Bugfix: Unwanted drawn point when prevCanvasX is 0
Check for new options before updating synchronised graphs (Fixes danvk#760)
Implement label_v
* indexFromSetName works with trailing invisible sets If the last set(s) have their visibility set to false, their names would not be added to `setIndexByName_`, so `indexFromSetName` would not be able to find them. This fixes that problem. * Corrected test. * Properly clone graph options
* [utils] dateString_ display Milliseconds if any * [utils] fix dateAxisLabelFormatter milliseconds * [util] dateString_: compute ms in frac * [utils] clean hmsString_ format * [utils] add milliseconds padding in hmsString_ * [develop] add note on npm install * [tests] add labelsDateMilliseconds test * [utils] add millis in dateAxisLabelFormatter * [tests] fix requested changes in labelsDateMillis * [auto_tests] add date_formats testMillisecondsDate
Move styles over to CSS
spelling fixes
1. The second argument of getOption should be marked as optional per jsdoc at: http://dygraphs.com/jsdoc/symbols/Dygraph.html#getOption 2. 'boolean' is typo'd as 'Boolean' in updateOptions.
Conflicts: src/dygraph.js
, test included. (danvk#877) * Added pixelRatio option, using where appropriate. Falls back to old behavior if not specified. Added to options reference, Added to Dygraph.prototype.resizeElements_, Added to rangeSelector.prototype.updateVisibility. * Fixed bug in range-selector pixelRatio implementation, tests pass * added test for the pixelRatio option, properly run. First fails without change, then passes after change. * Added pull request suggestions Fix typo in docs, documented a float type, Simplified method of reading option. * Added note about pixelRatio affecting resolution
* Add milliseconds granularity wtih changes from danvk#777 with suggestions taken into account and mergeable with master. * Fix granularities according to original PR. * Add assertions for millisecond granularities * Add an example for labels below SECONDLY granularity
…e start (danvk#896) Adding fields to a structure after it is created can be slow on some browsers, like Chrome. Adding a demo to benchmark many points, this seems to speed up my Chromium from about 2.8-3s to about 1.8s. Thanks to Christopher Palmer (@thecav) for the analysis and specific suggestion.
This format is problematic, because it causes error: Couldn't parse 20035000 as a date ... Couldn't parse 20251000 as a date There should be parser added, that will support this format (20251000) example data data: "dist sum↵20033000 49↵20034000 48↵20035000 48↵20036000"
Fixes issue danvk#984 (Couldn't parse 20035000 as a date)
|
Do any of these changes visibly impact our current users' experiences? |
|
No - There are no css changes. And I observed no behavior changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
House keeping: Update opti's fork with upstream changes
History:
opti-developbranch is Opti's fork of https://github.com/danvk/dygraphs and is the default branch for Opti.-0400) which was version 2.0 of dygraphs + Opti's changes in
optiDevelopUpdate.opti-develop(this is point of this pull request)