Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper data type detection (Couldn't parse 20033000 as a date) #984

Closed
lmizinski opened this issue Feb 18, 2020 · 1 comment
Closed

Improper data type detection (Couldn't parse 20033000 as a date) #984

lmizinski opened this issue Feb 18, 2020 · 1 comment

Comments

@lmizinski
Copy link
Collaborator

Dygraphs version:
2.1.0

JsFiddle showing error:
https://jsfiddle.net/2pcu7swo/2/

I discovered the nature of problem. Data with X values like the one in example are treated as date values, and then are parsed as date which results in error:
"Couldn't parse 20033000 as a date"

The main problem here is that 20033000 should never be treated as date by default. It greatly limits library. Date can always be passed in regular data format, like 2003-30-00 if necessary. Or there could be flag added, that would force library to treat value as date.

I will provide pull request with solution for this problem.

@lmizinski lmizinski changed the title Improper data type detection Improper data type detection (Couldn't parse 20033000 as a date) Feb 18, 2020
lmizinski pushed a commit to lmizinski/dygraphs that referenced this issue Feb 20, 2020
lmizinski added a commit that referenced this issue Feb 20, 2020
Fixes issue #984 (Couldn't parse 20035000 as a date)
pawelzwronek pushed a commit to pawelzwronek/dygraphs that referenced this issue Oct 17, 2020
pawelzwronek added a commit to pawelzwronek/dygraphs that referenced this issue Oct 17, 2020
@mirabilos
Copy link
Collaborator

should be fixed in 2.1.2+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants