ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape #132

OS-giulianasilva · 2023-05-05T14:56:50Z

This PR is for fix the updated coordinates not being passed to the OnDrawChange event.

What was happening

It didn't exist a method o get the updated shape coordinates.
The updated coordinates were not being passed as an argument to the ShapeProviderEvent.

What was done

Created the getShapeProperties method for all shapes. This method returns the updated shape coordinates.
In ShapeProviderEvent: Added an argument to trigger method to pass the updated shape coordinates.
In AbstractDrawShape: Modified the _setOnChangeEvent method to pass the updated shape coordinates when triggering the DrawingToolsEvent.
In AbstractProviderEvent:
- Created the _triggerShapeChangedEvent method that get the updated shape coordinates and trigger the Shape event.
- In the _buildProvider method, passed the _triggerShapeChangedEvent as the providerObjectListener handler.

Test Steps

Go to a page with Maps with DrawingTools AddIOns
Create a shape
Modify the shape
Check if the Coordinates and Location parameters of OnDrawingChange event changed accordingly.

Checklist

tested locally
documented the code
clean all warnings and errors of eslint
requires changes in OutSystems (if so, provide a module with changes)
requires new sample page in OutSystems (if so, provide a module with changes)

src/OSFramework/Maps/Event/Shape/ShapeProviderEvent.ts

src/Providers/Maps/Google/DrawingTools/AbstractDrawShape.ts

src/Providers/Maps/Leaflet/Shape/AbstractProviderShape.ts

src/Providers/Maps/Leaflet/Shape/Rectangle.ts

sonarqubecloud · 2023-05-08T15:50:20Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
51.1% Duplication

rugoncalves

Nicely done!

* Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com> * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet --------- Co-authored-by: gbnm <goncalo.martins@outsystems.com> Co-authored-by: João Ferreira <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com> Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com>

* Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com> * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Update Map.css Added CSS class .runtime-staticMap-container-hide * Update Map.css * Increase Maps version to 1.6.7 * Adding git action * Adding workflow to generate documentation in dev * Changes in workflows * Create main-push.yml * Changing workflow name * Update dev-pr.yml * Moving actions into folder * Chaning workflow to use new folder * Adding types to events * Missing parameter, when not passed structure * Missing parameter * Initial changes * Lint changes * Changing input from value to propertyValue * Improving variable name * Fixing sonarcloud findings * Sonar cloud feedback * More sonarcloud feedback * Changing the way addresses are converted * Removing the apiKey parameter * Adding sonarcloud lint * Fix auto merge problem * Add function to easily check if a number is valid * Explicitly set type of size as number * Validating that height and width are bigger than 0 * Fix duplicated methods on Circle --------- Co-authored-by: gbnm <goncalo.martins@outsystems.com> Co-authored-by: Giuliana Silva <108938618+OS-giulianasilva@users.noreply.github.com> Co-authored-by: João Ferreira <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com> Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com> Co-authored-by: rug <rmfgoncalves@gmail.com>

* Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com> * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Update Map.css Added CSS class .runtime-staticMap-container-hide * Update Map.css * Increase Maps version to 1.6.7 * Adding git action * Adding workflow to generate documentation in dev * Changes in workflows * Create main-push.yml * Changing workflow name * Update dev-pr.yml * Moving actions into folder * Chaning workflow to use new folder * Adding types to events * Missing parameter, when not passed structure * Missing parameter * Initial changes * Lint changes * Changing input from value to propertyValue * Improving variable name * Fixing sonarcloud findings * Sonar cloud feedback * More sonarcloud feedback * Changing the way addresses are converted * Removing the apiKey parameter * Adding sonarcloud lint * Fix auto merge problem * Add function to easily check if a number is valid * Explicitly set type of size as number * Validating that height and width are bigger than 0 * Updated Version 1.6.8 and added .snyk file Updated Version 1.6.8 and added .snyk file * ROU-4431: Migrate OS Maps into ODC Maps v1.6.7 (#147) * Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com> * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Update Map.css Added CSS class .runtime-staticMap-container-hide * Update Map.css * Increase Maps version to 1.6.7 * Adding git action * Adding workflow to generate documentation in dev * Changes in workflows * Create main-push.yml * Changing workflow name * Update dev-pr.yml * Moving actions into folder * Chaning workflow to use new folder * Adding types to events * Missing parameter, when not passed structure * Missing parameter * Initial changes * Lint changes * Changing input from value to propertyValue * Improving variable name * Fixing sonarcloud findings * Sonar cloud feedback * More sonarcloud feedback * Changing the way addresses are converted * Removing the apiKey parameter * Adding sonarcloud lint * Fix auto merge problem * Add function to easily check if a number is valid * Explicitly set type of size as number * Validating that height and width are bigger than 0 * Fix duplicated methods on Circle --------- Co-authored-by: gbnm <goncalo.martins@outsystems.com> Co-authored-by: Giuliana Silva <108938618+OS-giulianasilva@users.noreply.github.com> Co-authored-by: João Ferreira <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com> Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com> Co-authored-by: rug <rmfgoncalves@gmail.com> --------- Co-authored-by: gbnm <goncalo.martins@outsystems.com> Co-authored-by: Giuliana Silva <108938618+OS-giulianasilva@users.noreply.github.com> Co-authored-by: João Ferreira <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com> Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com> Co-authored-by: rug <rmfgoncalves@gmail.com>

* Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Update Map.css Added CSS class .runtime-staticMap-container-hide * Update Map.css * Increase Maps version to 1.6.7 * Adding git action * Adding workflow to generate documentation in dev * Changes in workflows * Create main-push.yml * Changing workflow name * Update dev-pr.yml * Moving actions into folder * Chaning workflow to use new folder * Adding types to events * Missing parameter, when not passed structure * Missing parameter * Initial changes * Lint changes * Changing input from value to propertyValue * Improving variable name * Fixing sonarcloud findings * Sonar cloud feedback * More sonarcloud feedback * Changing the way addresses are converted * Removing the apiKey parameter * Adding sonarcloud lint * Fix auto merge problem * Add function to easily check if a number is valid * Explicitly set type of size as number * Validating that height and width are bigger than 0 * Updated Version 1.6.8 and added .snyk file Updated Version 1.6.8 and added .snyk file * ROU-4431: Migrate OS Maps into ODC Maps v1.6.7 (#147) * Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Update Map.css Added CSS class .runtime-staticMap-container-hide * Update Map.css * Increase Maps version to 1.6.7 * Adding git action * Adding workflow to generate documentation in dev * Changes in workflows * Create main-push.yml * Changing workflow name * Update dev-pr.yml * Moving actions into folder * Chaning workflow to use new folder * Adding types to events * Missing parameter, when not passed structure * Missing parameter * Initial changes * Lint changes * Changing input from value to propertyValue * Improving variable name * Fixing sonarcloud findings * Sonar cloud feedback * More sonarcloud feedback * Changing the way addresses are converted * Removing the apiKey parameter * Adding sonarcloud lint * Fix auto merge problem * Add function to easily check if a number is valid * Explicitly set type of size as number * Validating that height and width are bigger than 0 * Fix duplicated methods on Circle --------- --------- Co-authored-by: gbnm <goncalo.martins@outsystems.com> Co-authored-by: Giuliana Silva <108938618+OS-giulianasilva@users.noreply.github.com> Co-authored-by: João Ferreira <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com> Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com> Co-authored-by: rug <rmfgoncalves@gmail.com>

OS-giulianasilva added 6 commits April 17, 2023 11:37

Fix issue with Leaflet OnDrawingChange event

6db0d66

Remove unnecessary arguments

c31dc66

Fix OnDrawChange event for Google Maps

3c78565

Remove unnecessary arguments and comments

506a161

Add comments

78dfbf8

Fix eslint errors

b688aa7

OS-giulianasilva requested review from gnbm, joselrio, BenOsodrac, bmarcelino-fe, rugoncalves and JoaoFerreira-FrontEnd as code owners May 5, 2023 14:56

outsystemsbot bot added the cla:yes label May 5, 2023

Fix Code smell

16ac172

JoaoFerreira-FrontEnd previously approved these changes May 5, 2023

View reviewed changes

rugoncalves requested changes May 8, 2023

View reviewed changes

OS-giulianasilva added 2 commits May 8, 2023 16:40

Removed repeated code

33e4bd6

Add shape types

df7380a

OS-giulianasilva dismissed JoaoFerreira-FrontEnd’s stale review via df7380a May 8, 2023 15:44

Update ShapeProviderEvent.ts

d58cc72

OS-giulianasilva requested review from rugoncalves and JoaoFerreira-FrontEnd May 8, 2023 16:11

JoaoFerreira-FrontEnd approved these changes May 8, 2023

View reviewed changes

rugoncalves approved these changes May 9, 2023

View reviewed changes

OS-giulianasilva merged commit dddcd01 into dev May 9, 2023

OS-giulianasilva deleted the ROU-4222 branch May 9, 2023 12:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape #132

ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape #132

OS-giulianasilva commented May 5, 2023 •

edited

Loading

sonarqubecloud bot commented May 8, 2023

rugoncalves left a comment

ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape #132

ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape #132

Conversation

OS-giulianasilva commented May 5, 2023 • edited Loading

What was happening

What was done

Test Steps

Checklist

sonarqubecloud bot commented May 8, 2023

rugoncalves left a comment

Choose a reason for hiding this comment

OS-giulianasilva commented May 5, 2023 •

edited

Loading