Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4431: Migrate OS Maps into ODC Maps v1.6.7 #150

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

bmarcelino-fe
Copy link
Contributor

This PR is for:

  • Sign old commits
  • Migration OS Maps into ODC Maps v1.6.7

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

* Update asset version to 1.6.6

Updated asset version to 1.6.6.

* ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132)

* Fix issue with Leaflet OnDrawingChange event

* Remove unnecessary arguments

* Fix OnDrawChange event for Google Maps

* Remove unnecessary arguments and comments

* Add comments

* Fix eslint errors

* Fix Code smell

* Removed repeated code

* Add shape types

* Update ShapeProviderEvent.ts

* ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133)

* - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent;

* - change the return location on draging end (draw marker);

---------

Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com>

* Update Images.css

Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet

* Revert "Update Images.css"

This reverts commit 96154f3.

* Update Images.css

Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet

* Update Map.css

Added CSS class .runtime-staticMap-container-hide

* Update Map.css

* Increase Maps version to 1.6.7

* Adding git action

* Adding workflow to generate documentation in dev

* Changes in workflows

* Create main-push.yml

* Changing workflow name

* Update dev-pr.yml

* Moving actions into folder

* Chaning workflow to use new folder

* Adding types to events

* Missing parameter, when not passed structure

* Missing parameter

* Initial changes

* Lint changes

* Changing input from value to propertyValue

* Improving variable name

* Fixing sonarcloud findings

* Sonar cloud feedback

* More sonarcloud feedback

* Changing the way addresses are converted

* Removing the apiKey parameter

* Adding sonarcloud lint

* Fix auto merge problem

* Add function to easily check if a number is valid

* Explicitly set type of size as number

* Validating that height and width are bigger than 0

* Updated Version 1.6.8 and added .snyk file

Updated Version 1.6.8 and added .snyk file

* ROU-4431: Migrate OS Maps into ODC Maps v1.6.7 (#147)

* Update asset version to 1.6.6

Updated asset version to 1.6.6.

* ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132)

* Fix issue with Leaflet OnDrawingChange event

* Remove unnecessary arguments

* Fix OnDrawChange event for Google Maps

* Remove unnecessary arguments and comments

* Add comments

* Fix eslint errors

* Fix Code smell

* Removed repeated code

* Add shape types

* Update ShapeProviderEvent.ts

* ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133)

* - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent;

* - change the return location on draging end (draw marker);

---------

Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com>

* Update Images.css

Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet

* Revert "Update Images.css"

This reverts commit 96154f3.

* Update Images.css

Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet

* Update Map.css

Added CSS class .runtime-staticMap-container-hide

* Update Map.css

* Increase Maps version to 1.6.7

* Adding git action

* Adding workflow to generate documentation in dev

* Changes in workflows

* Create main-push.yml

* Changing workflow name

* Update dev-pr.yml

* Moving actions into folder

* Chaning workflow to use new folder

* Adding types to events

* Missing parameter, when not passed structure

* Missing parameter

* Initial changes

* Lint changes

* Changing input from value to propertyValue

* Improving variable name

* Fixing sonarcloud findings

* Sonar cloud feedback

* More sonarcloud feedback

* Changing the way addresses are converted

* Removing the apiKey parameter

* Adding sonarcloud lint

* Fix auto merge problem

* Add function to easily check if a number is valid

* Explicitly set type of size as number

* Validating that height and width are bigger than 0

* Fix duplicated methods on Circle

---------

Co-authored-by: gbnm <goncalo.martins@outsystems.com>
Co-authored-by: Giuliana Silva <108938618+OS-giulianasilva@users.noreply.github.com>
Co-authored-by: João Ferreira <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com>
Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com>
Co-authored-by: rug <rmfgoncalves@gmail.com>

---------

Co-authored-by: gbnm <goncalo.martins@outsystems.com>
Co-authored-by: Giuliana Silva <108938618+OS-giulianasilva@users.noreply.github.com>
Co-authored-by: João Ferreira <60441552+JoaoFerreira-FrontEnd@users.noreply.github.com>
Co-authored-by: OUTSYSTEMS\fmj <joao.maneul.ferreira@outsystems.com>
Co-authored-by: rug <rmfgoncalves@gmail.com>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

8.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@bmarcelino-fe bmarcelino-fe merged commit 206ba5a into odc-main Dec 14, 2023
8 of 9 checks passed
@bmarcelino-fe bmarcelino-fe deleted the rc1.6.7-odc-v3 branch December 14, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants