-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROU-11055: Adding Google Advanced Markers and Map Style Id properties #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoFerreira-FrontEnd
requested changes
Oct 3, 2024
OS-giulianasilva
previously approved these changes
Oct 4, 2024
JoaoFerreira-FrontEnd
previously approved these changes
Oct 7, 2024
Quality Gate failedFailed conditions |
OS-giulianasilva
approved these changes
Oct 7, 2024
JoaoFerreira-FrontEnd
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding Google Advanced Markers and the ability to use styles created in Google Style Console.
What was happening
With version
3.56
, google deprecated the classgoogle.maps.Marker
with the following message*:Additionally, when using the new
AdvancedMarkerElement
, it become necessary to use the attributemapId
, which is used to indicate the Map Style Id for the styles created in Google Style Console. However, by using it, the current styles stop working, and a new warning is displayed in the console**:*Consider WARNING1
**Consider WARNING2
What was done
Added a new configuration (
UseAdvancedMarker
) to allow the developer to define which version of the Marker should be used.Added a new configuration (
MapStyleId
) to allow the developer to pass the style Id as defined in the cloud console:Updated the version of the google maps being used from
3.55
to3.57
(see version list)Updated the version of OutSystems Maps to
2.0.0
Test Steps
Test 1 - happy path
a. Use Advance Markers: true
b. Deprecated Style: Standard
Test 2
a. Use Advance Markers: true
b. Deprecated Style: Retro
WARNING1
Test 3
a. Use Advance Markers: false
b. Deprecated Style: Retro
WARNING2
Test 4
a. Use Advance Markers: true
b. Deprecated Style: Standard
a. Use Advance Markers: false
b. Deprecated Style: Standard
WARNING1
Checklist