-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update surface area models #2895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge release branch back into dev
Adjusted surface area model to accept lower limit (amin), defaults to 0 #enh
Fix examples
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release #2895 +/- ##
=========================================
- Coverage 89.9% 89.7% -0.2%
=========================================
Files 148 148
Lines 8608 8660 +52
=========================================
+ Hits 7742 7776 +34
- Misses 866 884 +18 |
Fixed deprecation error coming from new Scipy and Numpy versions #maint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do another quick release to update the surface area models to accept an
amin
argument. The default that was included in the last version was not general enough.