Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color_distance needs to be installed from repo url #1

Closed
pietroppeter opened this issue Jun 24, 2020 · 3 comments
Closed

color_distance needs to be installed from repo url #1

pietroppeter opened this issue Jun 24, 2020 · 3 comments

Comments

@pietroppeter
Copy link

Hi, I did not add color_distance to nimble pakages, since I think it could be better to put it in chroma. I will open a PR in chroma and let's see if its accepted. If it is we can change requirement here to chroma. Otherwise I will add color_distance to packages.

In the meantime to satistfy the dependency you should use:

nimble install https://github.com/pietroppeter/color_distance
@PMunch
Copy link
Owner

PMunch commented Jun 25, 2020

Ah, woops. I was in a rush when I made the .nimble file and forgot to check. Fixed in 8b0428e

@PMunch PMunch closed this as completed Jun 25, 2020
@pietroppeter
Copy link
Author

ah right, you can put the url directly in the file! Once I close this (treeform/chroma#14) we can go back to chroma, I will open a PR here. It would be nice also to have here the script modified by @yardanico (see github-linguist/linguist#4866) which uses weave to parallelize and it outputs a different image (I like a lot your image with the blobs!). We could have both images in the repo.

@PMunch
Copy link
Owner

PMunch commented Jun 25, 2020

Yeah @Yardanico should make a PR here with his stuff. I'm also trying to create a more optimised version that I'll add when it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants