Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Nim's colour to better match the logo #4866

Merged
merged 3 commits into from May 27, 2020
Merged

Change Nim's colour to better match the logo #4866

merged 3 commits into from May 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2020

This PR changes Nim language's colour to better match the logo - from #37775b to #ffdf00

Description

For a long time I wondered why Nim has the green colour on GitHub, and today I decided to dig deeper in it. Turns out Nim was made green by the initial commit which added colours - c3d6fc5 and was never changed after that.
With this PR I want to make the colour more consistent with the logo and branding (most of it is the goldish yellow)

Checklist:

  • I am changing the color associated with a language

@ghost
Copy link
Author

ghost commented May 17, 2020

Alternatives to try: #ffe953

@ghost ghost changed the title Change Nim's colour to match the logo Change Nim's colour to better match the logo May 17, 2020
@ghost
Copy link
Author

ghost commented May 17, 2020

About feedback - is it fine if people just do thumbs up/down to this PR? I've spread this PR in all places in the community I know about, and some well-known Nim developers (including Nim's creator :P) already upvoted this PR. Of course we still need to wait a few more days so more people can vote on this change.

And now I need to find a good goldish-like colour for Nim, because these two seem to be too close to other ones

@ghost
Copy link
Author

ghost commented May 17, 2020

Found a working colour - #FFDF00, would it be fine?

@ghost ghost marked this pull request as ready for review May 17, 2020 19:57
@ThomasTJdev
Copy link

The latest proposed color in is too white'ish for me to read. It fades into the standard white background at Github and makes it hard for the eyes.

I would go for a darker yellow.

Current proposal in the PR (#ffdf00):

whiteish

Color inside the Nim crown ( #f3d400):

crownback

Darker yellow (#c9b31a):

blackish

@ghost
Copy link
Author

ghost commented May 20, 2020

@ThomasTJdev it's not for the code, it's for the color in language % of repos and in short view for repos (where there's a color near the language name)
See:

And both #f3d400 and #c9b31a fail the color proximity test

After this PR (with the current colour):

@ghost
Copy link
Author

ghost commented May 20, 2020

This is how Nim will look after this PR (JS seems to have one of the most similar colors to golden yellow):

@ThomasTJdev
Copy link

This is how Nim will look after this PR (JS seems to have one of the most similar colors to golden yellow):

Ahh - my mistake. Then I'm all in for your proposal - a 👍 is added.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your pull request and for taking the time to check with the community!

@pchaigno pchaigno requested a review from lildude May 24, 2020 09:05
@lildude lildude merged commit a2917b0 into github-linguist:master May 27, 2020
@lildude
Copy link
Member

lildude commented May 27, 2020

I'm going to need to revert this as it seems the colour proximity test didn't pick up a problem, but it is now on master:

  1) Failure:
TestColorProximity#test_color_proximity [/home/runner/work/linguist/linguist/test/test_color_proximity.rb:21]:
The following 1 languages have failing color thresholds. Please modify the hex color.
- Nim (#ffdf00) is too close to ["FFEC25", "ffdf00"]

We're going to need tweaking to resolve this.

@lildude
Copy link
Member

lildude commented May 27, 2020

I've now worked out why the passed before: Dafny got the #FFEC25 colour before Nim's change so it was merged first.

lildude added a commit that referenced this pull request May 27, 2020
@ghost ghost mentioned this pull request Jun 24, 2020
2 tasks
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants