add CIEDE2000 color distance #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking good. I'll approve when you are ready. |
treeform
reviewed
Jun 26, 2020
src/chroma/distance.nim
Outdated
| let | ||
| C1 = sqrt(c1.a^2 + c1.b^2) | ||
| C2 = sqrt(c2.a^2 + c2.b^2) | ||
| CM = 0.5*(C1 + C2) |
There was a problem hiding this comment.
0.5*(
I think there are some formatting things that nimpretty will fix.
There was a problem hiding this comment.
it was not fixed by nimpretty but I did it manually (I assume you imply spacing the '*')
src/chroma/distance.nim
Outdated
| else: | ||
| arctan2(x, y).radToDeg + 360 | ||
|
|
||
| func deltaE00*(c1, c2: ColorLAB, k_L, k_C, k_H = 1.float32): float32 = |
There was a problem hiding this comment.
k_L --> kL
Please follow Nim naming convention - no "_".
There was a problem hiding this comment.
done. I still have in that file some variable names that start with a Capital letter (although convention would want that only for types). Do you want me to adjust those too?
This reverts commit 98e97f0.
|
|
I think this looks great merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this adds the functionality in https://github.com/pietroppeter/color_distance
I did a bit of cleanup of original code but not too much. Tests work fine.
I still have to add some documentation. I see that you are using mddoc and morepretty, I will try to use that.