Remove the need to update the version in two places #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-nayar
commented
Feb 1, 2021
| @@ -1,2 +1,17 @@ | |||
| ## For more details on how to configure your build environment visit | |||
There was a problem hiding this comment.
The changes in this file were added by Android Studio automatically to fix some warnings.
There was a problem hiding this comment.
Those changes look good and are sensible.
amit-nayar
commented
Feb 1, 2021
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip |
There was a problem hiding this comment.
Upping the gradle version because there appears to be no side effects from doing so.
amit-nayar
commented
Feb 2, 2021
| @@ -44,7 +44,7 @@ flutter { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile 'com.android.support:multidex:1.0.3' | |||
| implementation 'com.android.support:multidex:1.0.3' | |||
There was a problem hiding this comment.
compile is deprecated
amit-nayar
commented
Feb 2, 2021
amit-nayar
changed the title
davidschreiber
approved these changes
Feb 2, 2021
| @@ -1,2 +1,17 @@ | |||
| ## For more details on how to configure your build environment visit | |||
There was a problem hiding this comment.
Those changes look good and are sensible.
Co-authored-by: David Schreiber-Ranner <davidschreiber@users.noreply.github.com>
amit-nayar
commented
Feb 2, 2021
|
|
||
| - Fixes versioning system to not require a manual update in two places. (#80) | ||
| - Updates Gradle version and enable AndroidX for Android plugin and example. (#80) | ||
| - Changes open source license to modified BSD instead of Apache. (#79) |
There was a problem hiding this comment.
Unrelated but missing from the changelog.
simoarpe
approved these changes
Feb 2, 2021
| @@ -31,10 +43,17 @@ if (pspdfkitVersion == null || pspdfkitVersion == '') { | |||
|
|
|||
| ext.pspdfkitMavenModuleName = 'pspdfkit' | |||
|
|
|||
| ext.pspdfkitFlutterVersion = '1.10.3' | |||
| // Get our library version from the top level pubspec.yaml file. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When doing a version bump, we should keep the values in
pubspec.yamlandconfig.gradlefor android the same.This PR uses a gradle Yaml library to parse the pubspec version and use it in the gradle config step.
I am also updating the gradle version and have applied some auto generated android studio fixes (commented) related to migrating to AndroidX.
Acceptance Criteria