-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need to update the version in two places #80
Changes from all commits
99c32b3
956d545
6c07607
054bb77
41ee041
776febd
5f583b1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,18 @@ | |
* UNAUTHORIZED REPRODUCTION OR DISTRIBUTION IS SUBJECT TO CIVIL AND CRIMINAL PENALTIES. | ||
* This notice may not be removed from this file. | ||
*/ | ||
|
||
buildscript { | ||
repositories { | ||
jcenter() | ||
} | ||
dependencies { | ||
classpath "org.yaml:snakeyaml:1.27" | ||
} | ||
} | ||
|
||
import org.yaml.snakeyaml.Yaml | ||
|
||
def localProperties = new Properties() | ||
def localPropertiesFile = rootProject.file('local.properties') | ||
if (localPropertiesFile.exists()) { | ||
|
@@ -31,10 +43,17 @@ if (pspdfkitVersion == null || pspdfkitVersion == '') { | |
|
||
ext.pspdfkitMavenModuleName = 'pspdfkit' | ||
|
||
ext.pspdfkitFlutterVersion = '1.10.3' | ||
// Get our library version from the top level pubspec.yaml file. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❤️ |
||
def pubspecFilePath = '../pubspec.yaml' | ||
def pubspecFile = rootProject.file(pubspecFilePath) | ||
if (!pubspecFile.exists()) { | ||
throw new GradleException("'pubspec.yaml' file not found. Expected at the top level of the Flutter repository.") | ||
} | ||
def pubspecYaml = new Yaml().load(pubspecFile.newInputStream()) | ||
ext.pspdfkitFlutterVersion = pubspecYaml.version | ||
|
||
ext.androidCompileSdkVersion = 29 | ||
ext.androidBuildToolsVersion = '29.0.1' | ||
ext.androidMinSdkVersion = 19 | ||
ext.androidTargetSdkVersion = 29 | ||
ext.androidGradlePluginVersion = '3.6.3' | ||
ext.androidGradlePluginVersion = '4.1.1' |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,17 @@ | ||
## For more details on how to configure your build environment visit | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The changes in this file were added by Android Studio automatically to fix some warnings. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those changes look good and are sensible. |
||
# http://www.gradle.org/docs/current/userguide/build_environment.html | ||
# | ||
# Specifies the JVM arguments used for the daemon process. | ||
# The setting is particularly useful for tweaking memory settings. | ||
# Default value: -Xmx1024m -XX:MaxPermSize=256m | ||
# org.gradle.jvmargs=-Xmx2048m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 | ||
# | ||
# When configured, Gradle will run in incubating parallel mode. | ||
# This option should only be used with decoupled projects. More details, visit | ||
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects | ||
# org.gradle.parallel=true | ||
#Mon Feb 01 09:50:51 GMT 2021 | ||
android.enableJetifier=true | ||
android.useAndroidX=true | ||
org.gradle.configureondemand=false | ||
org.gradle.jvmargs=-Xmx1536M | ||
org.gradle.configureondemand=false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#Mon Jul 16 16:27:42 CEST 2018 | ||
#Mon Feb 01 16:17:50 GMT 2021 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Upping the gradle version because there appears to be no side effects from doing so. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ flutter { | |
} | ||
|
||
dependencies { | ||
compile 'com.android.support:multidex:1.0.3' | ||
implementation 'com.android.support:multidex:1.0.3' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
testImplementation 'junit:junit:4.12' | ||
androidTestImplementation 'androidx.test:runner:1.1.1' | ||
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1' | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#Fri Jun 23 08:50:38 CEST 2017 | ||
#Tue Feb 02 09:21:10 GMT 2021 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated but missing from the changelog.