Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing version bump from pull request #238 #241

Closed
wants to merge 1 commit into from

Conversation

leoek
Copy link
Contributor

@leoek leoek commented Jul 1, 2019

Details

  • The tag 1.24.3 has to be created after merging this.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@nickwinder
Copy link
Contributor

Sorry about this! There's a couple of other places that needed changing, so I open a PR to get this done quick. I'll close this now.
#242

@nickwinder nickwinder closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants