Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 1.24.3 #242

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Bump version to 1.24.3 #242

merged 1 commit into from
Jul 1, 2019

Conversation

nickwinder
Copy link
Contributor

Details

Missing version bump from pull request #238

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@nickwinder nickwinder requested a review from radazzouz July 1, 2019 12:52
@nickwinder nickwinder self-assigned this Jul 1, 2019
@nickwinder nickwinder mentioned this pull request Jul 1, 2019
Closed
2 tasks
radazzouz
radazzouz approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@nickwinder nickwinder merged commit 93c7814 into master Jul 1, 2019
@nickwinder nickwinder deleted the nick/bump-version-missed branch July 1, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radazzouz radazzouz radazzouz approved these changes

Assignees

@nickwinder nickwinder

Labels
READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickwinder @radazzouz