Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsm303d driver move to PX4Accelerometer/PX4Magnetometer and cleanup #12566

Merged
merged 2 commits into from
Jul 29, 2019
Merged

lsm303d driver move to PX4Accelerometer/PX4Magnetometer and cleanup #12566

merged 2 commits into from
Jul 29, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Jul 27, 2019 •
edited
Loading

Saves 3 kilobytes of flash on fmu-v2.

image

@dagar
Copy link
Member Author

dagar commented Jul 27, 2019

Bench tested and compared with master.

sensors status (truncated)

master

INFO  [sensors] accel status:
INFO  [ecl/validation] validator: best: 0, prev best: 0, failsafe: NO (0 events)
INFO  [ecl/validation] sensor #1, prio: 75, state: OK
INFO  [ecl/validation] 	val:   2.8203, lp:   2.8328 mean dev:  -0.0004 RMS:   0.0881 conf:   1.0000
INFO  [ecl/validation] 	val:   4.1652, lp:   4.1282 mean dev:  -0.0001 RMS:   0.0837 conf:   1.0000
INFO  [ecl/validation] 	val:  -7.8524, lp:  -7.6321 mean dev:  -0.0009 RMS:   0.1038 conf:   1.0000
INFO  [sensors] mag status:
INFO  [ecl/validation] validator: best: 0, prev best: 0, failsafe: NO (0 events)
INFO  [ecl/validation] sensor #0, prio: 50, state: OK
INFO  [ecl/validation] 	val:  -0.5184, lp:  -0.5190 mean dev:   0.0000 RMS:   0.0006 conf:   1.0000
INFO  [ecl/validation] 	val:  -0.3836, lp:  -0.3841 mean dev:   0.0000 RMS:   0.0006 conf:   1.0000
INFO  [ecl/validation] 	val:   0.0572, lp:   0.0587 mean dev:   0.0000 RMS:   0.0012 conf:   1.0000

PR

INFO  [sensors] accel status:
INFO  [ecl/validation] validator: best: 0, prev best: 0, failsafe: NO (0 events)
INFO  [ecl/validation] sensor #1, prio: 75, state: OK
INFO  [ecl/validation] 	val:   2.8994, lp:   2.8475 mean dev:   0.0003 RMS:   0.0884 conf:   1.0000
INFO  [ecl/validation] 	val:   4.1435, lp:   4.1106 mean dev:   0.0011 RMS:   0.0826 conf:   1.0000
INFO  [ecl/validation] 	val:  -7.5350, lp:  -7.6370 mean dev:  -0.0009 RMS:   0.1025 conf:   1.0000
INFO  [sensors] mag status:
INFO  [ecl/validation] validator: best: 0, prev best: 0, failsafe: NO (0 events)
INFO  [ecl/validation] sensor #0, prio: 50, state: OK
INFO  [ecl/validation] 	val:  -0.5176, lp:  -0.5181 mean dev:  -0.0000 RMS:   0.0006 conf:   1.0000
INFO  [ecl/validation] 	val:  -0.3824, lp:  -0.3830 mean dev:  -0.0000 RMS:   0.0006 conf:   1.0000
INFO  [ecl/validation] 	val:   0.0596, lp:   0.0599 mean dev:  -0.0000 RMS:   0.0007 conf:   1.0000

@dagar dagar added this to the Release v1.10.0 milestone Jul 27, 2019
@dagar dagar requested a review from davids5 July 27, 2019 18:36
@weekly-digest weekly-digest bot mentioned this pull request Jul 28, 2019
Closed
@dagar dagar merged commit 7553112 into PX4:master Jul 29, 2019
@dagar dagar deleted the pr-lsm303d_cleanup branch July 29, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davids5 davids5 davids5 approved these changes

Assignees
No one assigned
Labels
Admin: Cleanup (housekeeping) 🧹 Admin: Enhancement (improvement) 💡
Projects
None yet
Milestone
Release v1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @davids5