Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

position_estimator_inav: move to examples (start deprecation) #11311

Merged
merged 1 commit into from
Jan 27, 2019
Merged

position_estimator_inav: move to examples (start deprecation) #11311

merged 1 commit into from
Jan 27, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Jan 27, 2019

@dagar dagar added this to the Release v1.9.0 milestone Jan 27, 2019
@dagar dagar requested review from LorenzMeier and TSC21 January 27, 2019 16:19
@dagar dagar force-pushed the pr-inav_deprecate branch from bd1a6ba to 0f2dc9e Compare January 27, 2019 17:01
@LorenzMeier
Copy link
Member

@dagar Did you update the estimator type selection param as well? I couldn't find that in the diff.

TSC21
TSC21 approved these changes Jan 27, 2019
View reviewed changes
Copy link
Member

@TSC21 TSC21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TSC21
Copy link
Member

TSC21 commented Jan 27, 2019

@dagar Did you update the estimator type selection param as well? I couldn't find that in the diff.

@LorenzMeier I think position_estimator_inav was out of the SYS_MC_EST_GROUP parameter already.

@LorenzMeier LorenzMeier merged commit 739a020 into PX4:master Jan 27, 2019
@dagar dagar deleted the pr-inav_deprecate branch January 27, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TSC21 TSC21 TSC21 approved these changes

@LorenzMeier LorenzMeier Awaiting requested review from LorenzMeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dagar @LorenzMeier @TSC21