-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/px4io move to uORB::Subscription #12222
Conversation
9afad9b
to
fe3ef2d
Compare
fe3ef2d
to
e14298d
Compare
Tested on Pixhawk 4 mini v5Modes Tested
Procedure Notes: Logs: Master |
Tested on Pixhawk 4 V5 Position Mode: Good.
Notes: pr Log: https://review.px4.io/plot_app?log=23a388a1-6012-4766-9d2c-060e82a3b26d master log: https://review.px4.io/plot_app?log=71a5aa74-1e6e-4c9c-ae20-2baff55f3daf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason that _t_actuator_controls_0
is not included?
It's the single subscription used for polling. |
Tested on PixRacer V4Modes Tested Position Mode: Good. Notes: Logs: Log Loaded master to see if the issue persists but this was not the case, the vehicle was ready to fly in position in less than 30 seconds.** MASTER COMPARISON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'm ok with this.
This should be tested on boards with a px4io (pixhawk, pixhawk 3 pro, pixhawk 4).