Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/px4io move to uORB::Subscription #12222

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Conversation

dagar
Copy link
Member

@dagar dagar commented Jun 9, 2019

This should be tested on boards with a px4io (pixhawk, pixhawk 3 pro, pixhawk 4).

@dagar dagar requested review from julianoes and a team June 9, 2019 14:25
@dagar dagar force-pushed the pr-px4io_subscription branch 4 times, most recently from 9afad9b to fe3ef2d Compare June 9, 2019 14:58
@dagar dagar force-pushed the pr-px4io_subscription branch from fe3ef2d to e14298d Compare June 9, 2019 15:17
@Junkim3DR
Copy link

Tested on Pixhawk 4 mini v5

Modes Tested

  • Position Mode: Good.
  • Altitude Mode: Good.
  • Stabilized Mode: Good.
  • Mission Plan Mode (Automated): Good.
  • RTL: Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:
PR 12222

Master

@dannyfpv
Copy link

Tested on Pixhawk 4 V5
Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

  • Procedure
    Arm and Take off in stabilized mode, position mode, altitude, and mission mode

Notes:
No issues noted, good flight in general.

pr Log:

https://review.px4.io/plot_app?log=23a388a1-6012-4766-9d2c-060e82a3b26d

master log:

https://review.px4.io/plot_app?log=71a5aa74-1e6e-4c9c-ae20-2baff55f3daf

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason that _t_actuator_controls_0 is not included?

@dagar
Copy link
Member Author

dagar commented Jun 11, 2019

What's the reason that _t_actuator_controls_0 is not included?

It's the single subscription used for polling.

@jorge789
Copy link

jorge789 commented Jun 11, 2019

Tested on PixRacer V4

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.
Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoints activate RTL and see landing behavior.

Notes:
No issues noted good flight in general.

Logs:
https://review.px4.io/plot_app?log=ed875697-5ab3-4076-9be3-eed30fd44085

Log
https://review.px4.io/plot_app?log=bd3bb4eb-33eb-4d42-a695-c3bb1e3949d9
Note:
**Vehicle was unable to get position mode, satellites were not enough.

Loaded master to see if the issue persists but this was not the case, the vehicle was ready to fly in position in less than 30 seconds.**

MASTER COMPARISON
https://review.px4.io/plot_app?log=6708497f-314e-4e35-a43e-2c3d1f6c59d7

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'm ok with this.

@dagar dagar merged commit 648e7de into PX4:master Jun 16, 2019
@dagar dagar deleted the pr-px4io_subscription branch June 16, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants