-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
px4fmu move to WQ with uORB callback scheduling #12224
Conversation
7cd32f9
to
9b44e9c
Compare
9b44e9c
to
894fcb2
Compare
312999b
to
a67e42b
Compare
58b098e
to
49f9c3a
Compare
TODO: review oneshot |
49f9c3a
to
db62243
Compare
FYI @mcsauder ready to do this one for real. |
Awesome @dagar ! Well done! Here are 2 flights that somehow became three logs for you, pixhawk 4 mini, 250 generic quad. This PR flies fantastic, be sure to look at the last log. From these flights I see no reason not to proceed with this work full steam. Position hold only: Multiple flight modes exercised: Nice work! |
Tested on Pixhawk 4mini v5:Modes Tested
Procedure Notes: Log:
Master |
Tested on Pixhawk 2 Cube v3:Modes Tested
Procedure Notes: Log:
Master |
Tested on PixRacer V4:Modes Tested Position Mode: Good. Notes: Log: https://review.px4.io/plot_app?log=33c41165-a41c-4860-8621-1b381a914f90 Master: |
Revisit after #12225. TODO: test oneshot |
3c5e72c
to
e1b4804
Compare
888b2bf
to
a52661e
Compare
96b7e33
to
e8a1108
Compare
d9e225c
to
b07eea1
Compare
6e2f1d5
to
69f9e62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential threadding issue due to work queue switching that I don't see being prevented.
@Tony3dr the holybro QAV250 is set to Oneshot by default.
Tested on Omnibus with Oneshot, still works.
942cda4
to
c71e95d
Compare
c71e95d
to
9b2fd81
Compare
Requires #12207 before merging.Background - #12207
This pull request moves the px4fmu driver (mixing + pwm output) to the new WQ. If mixing the primary actuator controls it runs in the rate_ctrl WQ (highest priority), otherwise it runs in hp_default. Either way it's event driven on new actuator_control publications, which removes the need to optionally run as a task (SYS_FMU_TASK).
Testing
fmu with no mixer (test safety button on fmu-v4)(N/A)