-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlightTasks: switch to uORB::Subscription #13039
Conversation
3c68a75
to
7f563ec
Compare
This also saves about 1.1 KB of flash on fmu-v2. |
d6bec1c
to
e7faf3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me.
@PX4/testflights could you test this across all the normal multicopter modes? |
Tested on PixRacer V4:Flight Card 1 Modes Tested: Procedure: Notes: Flight Card 2 Modes Tested Procedure Note: Flight Card 3 Modes Tested Procedure Note: Flight Card 4 Procedure Logs: Flight card 2: https://review.px4.io/plot_app?log=54654f33-f74d-4e12-89d7-7d3d08f684fc Flight card 3: https://review.px4.io/plot_app?log=ad324476-f95c-44ba-bf92-6c03ec8df39b Flight card 4: https://review.px4.io/plot_app?log=baa4ab5b-e500-4dac-930e-19154ae7e240 |
Tested on Pixhawk4 V5: Modes Tested: Procedure: Notes: Flight Card 2 Modes Tested Procedure Note: Flight Card 3 Modes Tested Procedure Note: Flight Card 4 Procedure Logs: |
Thanks everyone. |
Switching to uORB::Subscription from uORB::SubscriptionPollable is slightly faster and safer. There are no dynamic allocations, so we can get rid of the SubscriptionArray. The minor downside in this case is that there isn't a helper to update all of them in a single pass, so each needs to be updated in updateInitialize().
This is working towards removing SubscriptionPollable entirely. It's a wrapper around the orb C api.