Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic changes to navigator_params #14065

Closed
wants to merge 2 commits into from
Closed

Cosmetic changes to navigator_params #14065

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31dd135
Cosmetic changes to navigator_params
LowOrbitIonCannon Jan 30, 2020
db2dbc8
Update navigator_params.c
LowOrbitIonCannon Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/modules/navigator/navigator_params.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,28 +128,24 @@ PARAM_DEFINE_FLOAT(NAV_MC_ALT_RAD, 0.8f);
PARAM_DEFINE_INT32(NAV_TRAFF_AVOID, 1);

/**
* Set NAV TRAFFIC AVOID RADIUS MANNED
* Set avoidance radius/distance for manned vehicles (ADS-B/FLARM).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this relatively short for QGC.

Screenshot from 2020-02-02 12-52-07

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could perhaps change these to

Set ADS-B/FLARM avoidance radius.

and

Set UTM avoidance radius.

The extended description covers the detail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no opinion on the optimal solution

*
* Defines the Radius where NAV TRAFFIC AVOID is Called
* For Manned Aviation
* Defines the avoidance radius/distance at which the avoidance action is triggered for manned vehicles (ADS-B/FLARM).
*
* @unit m
* @min 500
*
* @group Mission
*/
PARAM_DEFINE_FLOAT(NAV_TRAFF_A_RADM, 500);

/**
* Set NAV TRAFFIC AVOID RADIUS
* Set avoidance radius/distance for unmanned vehicles (UTM_GLOBAL_POSITION).
*
* Defines the Radius where NAV TRAFFIC AVOID is Called
* For Unmanned Aviation
* Defines the avoidance radius/distance at which the avoidance action is triggered for unmanned vehicles (UTM_GLOBAL_POSITION).
*
* @unit m
* @min 10
* @max 500
*
* @group Mission
*/
PARAM_DEFINE_FLOAT(NAV_TRAFF_A_RADU, 10);
Expand Down