Cosmetic changes to navigator_params #14065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per suggestion.
dagar
previously approved these changes
Jan 30, 2020
mhkabir
reviewed
Jan 30, 2020
mhkabir
reviewed
Jan 30, 2020
dagar
reviewed
Feb 2, 2020
| @@ -128,28 +128,24 @@ PARAM_DEFINE_FLOAT(NAV_MC_ALT_RAD, 0.8f); | |||
| PARAM_DEFINE_INT32(NAV_TRAFF_AVOID, 1); | |||
|
|
|||
| /** | |||
| * Set NAV TRAFFIC AVOID RADIUS MANNED | |||
| * Set avoidance radius/distance for manned vehicles (ADS-B/FLARM). | |||
There was a problem hiding this comment.
I would keep this relatively short for QGC.
There was a problem hiding this comment.
Could perhaps change these to
Set ADS-B/FLARM avoidance radius.
and
Set UTM avoidance radius.
The extended description covers the detail.
There was a problem hiding this comment.
I have no opinion on the optimal solution
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
|
Closing because the source branch disappeared (which chokes Jenkins). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @hamishwillee suggestion from this PR: #13159 .
Maybe we should add, that Unmanned collision avoidance is ONLY and ALWAYS triggered if a UTM_Globalposition message is received.
Eg. the Two Failure Cases:
-Manned aviation that sends UTM_Global_position is detected (as Unmanned)
If it has both Mavlink and ADSB it will be received twice.
-Unmanned aviation that does not send UTM_Global_position is not.
(UTM_Global_Position also needs to be received by mavlink on the Drone)
#13159