FlightTaskOrbit: parameterize hardcoded maximum radius #20012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
For safety/dummy proofing reasons the radius of a multicopter orbit is limited. There were use cases recently that required more than 100m orbit radius limit and that's why I increased the hardcoded limit in #19362 The ground station does not know what the limit is but allows the user to plan an arbitrary radius which then gets rejected by the autopilot.
Describe your solution
For these reasons, I made the maximum radius configurable.
Describe possible alternatives
Alternatively we could remove the maximum radius limit altogether.
- That would allow an infinite unreasonable radius
+ For dummy proofing 1 km radius is already quite large
+ Slightly less complexity and code
Test data / coverage
This was simulation tested separately and together with client ground station code to limit the radius correctly.