Increase orbit radius limit & reject out of range radius commands #19362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
For certain use cases the limit is just too low and if the limit is exceeded currently there a bug where the radius is just pruned instead of not executing the out of range orbit command.
Note: Not rejecting out of range radiuses is a regression:
9bd46be#diff-89127f427c1fc4e2fb02b97822ec75dc1bc7a4690ae4cd3aba8bc4f811250717L61
Describe your solution
Makes it configurable by parameter. I'm open to suggestions for the default.
Fixes the bug by not acknowledging the command and stopping instead of executing the Orbit.
This is already better than just changing the radius and then starting to execute but it should be further improved with e.g. an error message and possibly by switching mode.
Test data / coverage
SITL testing with out-of-range radiuses and hitting the limit by stick input.