Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten messages to prevent clipping in QGroundControl #24080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sdomoszlai13
Copy link

@sdomoszlai13 sdomoszlai13 commented Dec 6, 2024

Solved Problem

When I was working with QGroundControl I found that some 'Preflight Fail' messages are clipped (see e.g. attached image).

There's a 50-character limit to these messages defined by the STATUSTEXT MAVLink message. Longer messages are clipped.

In this PR, I reformulated the messages that are longer than 50 characters.

Solution

  • Reformulate messages longer than 50 characters

Changelog Entry

For release notes:

Fixed clipped messages in QGroundControl
New parameter: -
Documentation: -

Alternatives

We could also increase the character limit of the STATUSTEXT message

Test coverage

  • Unit/integration test: ...
  • Simulation/hardware testing logs: ...

Critical bug that needs backporting?

No

Context

image

@sdomoszlai13 sdomoszlai13 marked this pull request as ready for review December 6, 2024 13:03
@sdomoszlai13
Copy link
Author

@bkueng @sfuhrer Could you take a look? I don't have the permission to add you as reviewers here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant