Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten messages to prevent clipping in QGroundControl #24080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ void AirspeedChecks::checkAndReport(const Context &context, Report &reporter)
events::Log::Error, "Airspeed too high", airspeed_validated.calibrated_airspeed_m_s, arming_max_airspeed_allowed);

if (reporter.mavlink_log_pub()) {
mavlink_log_critical(reporter.mavlink_log_pub(), "Preflight Fail: Airspeed too high - check airspeed calibration");
mavlink_log_critical(reporter.mavlink_log_pub(), "Preflight Fail: Airspeed too high");
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ void DistanceSensorChecks::checkAndReport(const Context &context, Report &report
events::Log::Error, "No valid data from distance sensor {1}", instance);

if (reporter.mavlink_log_pub()) {
mavlink_log_critical(reporter.mavlink_log_pub(), "Preflight Fail: no valid data from distance sensor %u", instance);
mavlink_log_critical(reporter.mavlink_log_pub(), "Preflight Fail: No valid distance sensor %u data", instance);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ void FailureDetectorChecks::checkAndReport(const Context &context, Report &repor
events::Log::Critical, "Failure triggered by external system");

if (reporter.mavlink_log_pub()) {
mavlink_log_critical(reporter.mavlink_log_pub(), "Preflight Fail: Failure triggered by external system");
mavlink_log_critical(reporter.mavlink_log_pub(), "Preflight Fail: Failure caused by external system");
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ void RcAndDataLinkChecks::checkAndReport(const Context &context, Report &reporte
log_level, "No connection to the ground control station");

if (gcs_connection_required && reporter.mavlink_log_pub()) {
mavlink_log_warning(reporter.mavlink_log_pub(), "Preflight Fail: No connection to the ground control station\t");
mavlink_log_warning(reporter.mavlink_log_pub(), "Preflight Fail: No connection to the GCS");
}

} else {
Expand Down
Loading