Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

EKF drop unused timestamp from collect_gps() and pass data by const reference #584

Merged
merged 2 commits into from
Mar 5, 2019
Merged

EKF drop unused timestamp from collect_gps() and pass data by const reference #584

merged 2 commits into from
Mar 5, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Mar 5, 2019 •
edited
Loading

@dagar dagar added the ekf label Mar 5, 2019
@dagar dagar requested a review from mhkabir March 5, 2019 18:06
@dagar dagar mentioned this pull request Mar 5, 2019
Merged
@dagar dagar requested a review from bartslinger March 5, 2019 18:06
@fvantienen
Copy link
Contributor

The only warning I still get now is:

estimator_interface.h:172:46: warning: unused parameter ‘gps’ [-Wunused-parameter]
  virtual bool collect_gps(const gps_message &gps) { return true; }

But next to that it works fine.

@dagar dagar force-pushed the pr-ecl_ekf_unused branch 4 times, most recently from d87384c to 3830cb3 Compare March 5, 2019 18:33
@dagar dagar force-pushed the pr-ecl_ekf_unused branch from 3830cb3 to 25aa9e2 Compare March 5, 2019 18:35
@dagar
Copy link
Member Author

dagar commented Mar 5, 2019

Ok, I think I've got them all now. Please review.

@fvantienen
Copy link
Contributor

Tested and works!

bartslinger
bartslinger approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@bartslinger bartslinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dagar dagar merged commit a85d3a4 into master Mar 5, 2019
@dagar dagar deleted the pr-ecl_ekf_unused branch March 5, 2019 22:26
@priseborough priseborough added the non-functional Used for code changes that do not change functionality label Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartslinger bartslinger bartslinger approved these changes

@mhkabir mhkabir Awaiting requested review from mhkabir

Assignees
No one assigned
Labels
ekf non-functional Used for code changes that do not change functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused parameters warning
4 participants
@dagar @fvantienen @bartslinger @priseborough