Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add set default dtype, get default dtype #26006

Merged
merged 2 commits into from
Aug 18, 2020
Merged

add set default dtype, get default dtype #26006

merged 2 commits into from
Aug 18, 2020

Conversation

ForFishes
Copy link
Member

PR types

New features

PR changes

APIs

Describe

add "set_default_dtype" ,"get_default_dtype"

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 6, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jzhang533
jzhang533 requested changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may need to define alias in 'python/paddle/init.py ', so that the api could be exposed as paddle.set_default_dtype

jzhang533
jzhang533 previously approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ForFishes ForFishes closed this Aug 14, 2020
@ForFishes ForFishes reopened this Aug 14, 2020
@zhiqiu zhiqiu self-requested a review August 14, 2020 06:18
zhiqiu
zhiqiu previously approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This PR changes Linear, is it consistent with the old models?

@zhiqiu zhiqiu self-requested a review August 14, 2020 06:23
@ForFishes ForFishes dismissed stale reviews from zhiqiu and jzhang533 via 160d76a August 14, 2020 14:01
jzhang533
jzhang533 approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

XiaoguangHu01
XiaoguangHu01 approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForFishes ForFishes merged commit fd0051b into PaddlePaddle:develop Aug 18, 2020
@ForFishes ForFishes deleted the global_dtype branch August 18, 2020 08:23
@zhwesky2010 zhwesky2010 mentioned this pull request Aug 19, 2020
Merged
@pangyoki pangyoki mentioned this pull request Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

@jzhang533 jzhang533 jzhang533 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ForFishes @jzhang533 @zhiqiu @XiaoguangHu01